[Docs] improve the LoRA doc. #4838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
stevhliu
approved these changes
Aug 30, 2023
Member
stevhliu
left a comment
stevhliu
left a comment
There was a problem hiding this comment.
Niceee, thanks for adding these! 🔥
|
|
||
| * [text_to_image/README_sdxl.md](https://github.com/huggingface/diffusers/blob/main/examples/text_to_image/README_sdxl.md) | ||
| * [dreambooth/README_sdxl.md](https://github.com/huggingface/diffusers/blob/main/examples/dreambooth/README_sdxl.md) | ||
| Here is an example: |
Member
There was a problem hiding this comment.
Maybe also add some introductory text here instead of abruptly dropping the user straight into the code. Something like:
You can also load checkpoints from TheLastBen by specifying the model id and filename in the [`~diffusers.loaders.LoraLoaderMixin.load_lora_weights`] function:
Co-authored-by: Steven Liu <[email protected]>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* improve the LoRA doc. * include fuse_lora and unfuse_lora * Apply suggestions from code review Co-authored-by: Steven Liu <[email protected]> --------- Co-authored-by: Steven Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TheLastBenLoRA.fuse_lora()andunfuse_lora()APIs in theLoraLoaderMixin.I think it'll be important to include these minor changes to prepare for the release.