[SDXL Lora] Fix last ben sdxl lora #4797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I ran all LoRAIntegration Tests: and by lowering the precision a bit (to 5e-3) all tests pass. Merging this one now so that we don't run into too many merge conflicts with other PRs (cc @sayakpaul): |
|
The documentation is not available anymore as the PR was closed or merged. |
| new_state_dict[new_key] = state_dict.pop(key) | ||
|
|
||
| if is_all_unet and len(state_dict) > 0: | ||
| if len(state_dict) > 0: |
Contributor
Author
There was a problem hiding this comment.
Refactor here a bit by moving "adding text encoder keys" further up to have stronger check/assert here
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* Fix last ben sdxl lora * Correct typo * make style
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* Fix last ben sdxl lora * Correct typo * make style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes: #4302