Skip to content

adding more typehints to DDIM scheduler #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 16, 2022
Merged

adding more typehints to DDIM scheduler #456

merged 7 commits into from
Sep 16, 2022

Conversation

@vishnu-anirudh
Copy link
Contributor

@vishnu-anirudh vishnu-anirudh commented Sep 9, 2022

Adding more type hints to DDIM scheduler to make readability better.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 9, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@natolambert
Copy link
Contributor

natolambert commented Sep 10, 2022 •
edited
Loading

Hey @vishnu-anirudh, this looks great. Can you run make quality to get the last check to pass, then we should be good to merge this!

(Or I think its just the list order of from typing import Optional, Tuple, Union, List ), List needs to go first? I'm not an expert in isort.

@vishnu-anirudh
Copy link
Contributor Author

vishnu-anirudh commented Sep 11, 2022

Thank you @natolambert, yes isort did the trick.

patrickvonplaten
patrickvonplaten approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@patrickvonplaten patrickvonplaten merged commit a0558b1 into huggingface:main Sep 16, 2022
patrickvonplaten added a commit that referenced this pull request Sep 16, 2022
@patrickvonplaten
Revert "adding more typehints to DDIM scheduler (#456)"
6799919 
This reverts commit a0558b1.
@patrickvonplaten patrickvonplaten mentioned this pull request Sep 16, 2022
Merged
patrickvonplaten added a commit that referenced this pull request Sep 16, 2022
@patrickvonplaten
Revert "adding more typehints to DDIM scheduler" (#533)
8897217 
Revert "adding more typehints to DDIM scheduler (#456)"

This reverts commit a0558b1.
@patrickvonplaten
Copy link
Contributor

patrickvonplaten commented Sep 16, 2022

Hey @vishnu-anirudh,

Super sorry, I just noticed that we actually are making our schedulers framework-specific now (cc @kashif ) so that all arrays should not get a numpy type hint anymore.

Very sorry 🙏

@kashif could you maybe link your PR here so that maybe we can improve the type hints there once it's ready? :-)

@kashif
Copy link
Contributor

kashif commented Sep 16, 2022

Apologies! Please continue to check in to PR #534

@vishnu-anirudh
Copy link
Contributor Author

vishnu-anirudh commented Sep 20, 2022

Hello @patrickvonplaten

That's not a problem. I am happy to fill in the gaps wherever required after this commit is merged.

@vishnu-anirudh vishnu-anirudh deleted the type_ddim_diffuser branch September 20, 2022 21:09
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@vishnu-anirudh
adding more typehints to DDIM scheduler (huggingface#456)
b6959e4 
* adding more typehints

* resolving mypy issues

* resolving formatting issue

* fixing isort issue

Co-authored-by: V Vishnu Anirudh <[email protected]>
Co-authored-by: V Vishnu Anirudh <[email protected]>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@patrickvonplaten
Revert "adding more typehints to DDIM scheduler" (huggingface#533)
14caf7c 
Revert "adding more typehints to DDIM scheduler (huggingface#456)"

This reverts commit a0558b1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vishnu-anirudh @HuggingFaceDocBuilderDev @natolambert @patrickvonplaten @kashif