Add Min-SNR weighting strategy to lora script #3084
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
cc @sayakpaul could you check here? |
sayakpaul
approved these changes
Apr 20, 2023
Contributor
Author
|
Based on a local experiment, the benefits of min-snr strategy depends on the datasets used. Closing this PR for now. |
Member
|
@wfng92 not sure why you closed the PR. It was perfectly fine for us to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2899 added the Min-SNR weighting strategy to the base
train_text_to_image.pyscript, but left out thetrain_text_to_image_lora.pyscript. This PR apply the same code snippets totrain_text_to_image_lora.pysince the underlying code structure is similar between both scripts.