-
Notifications
You must be signed in to change notification settings - Fork 6.5k
[bug fix] dpm multistep solver duplicate timesteps #2969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug fix] dpm multistep solver duplicate timesteps #2969
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
fd68368 to
0ee3350
Compare
|
awesome! having a look! |
sayakpaul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean <3
Let's maybe also add a small test?
patrickvonplaten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool fix
|
Agree that adding a short test would be nice |
|
added tests and fixes to a few other schedulers here: williamberman#1 |
|
Thanks! @kashif I made a tweak to the commit by
|
a106257 to
e50594e
Compare
reported in slack by @kashif. When using same number of inference steps as training steps, We're using np.linspace with number of samples greater than the stop - start. This leads to duplicates