[Save Pretrained] Remove dead code lines that can accidentally remove pytorch files #2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| weights_name = SAFETENSORS_WEIGHTS_NAME if safe_serialization else WEIGHTS_NAME | ||
|
|
||
| # Clean the folder from a previous save |
Contributor
Author
There was a problem hiding this comment.
This part of the code is unnecessary since we don't have sharded checkpoints yet
|
The documentation is not available anymore as the PR was closed or merged. |
patrickvonplaten
changed the title
pcuenca
approved these changes
Jan 19, 2023
Member
pcuenca
left a comment
pcuenca
left a comment
There was a problem hiding this comment.
Sorry, I didn't fully understand the logic when I saw this fragment in the previous PR, but didn't check how it worked. Should have asked!
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
… pytorch files (huggingface#2038) correct safetensors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting from pytorch_model.bin to safetensors format, currently pytorch_model.bin files can be deleted because diffusers confuses the "sharded" folder structure with the always present folder saving format.
Since we don't have sharded checkpointing (yet) in diffusers, we will delete the code for now.