fix: resize transform now preserves aspect ratio #1804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
patil-suraj
approved these changes
Dec 27, 2022
Contributor
patil-suraj
left a comment
patil-suraj
left a comment
There was a problem hiding this comment.
Good catch, thanks a lot for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example train_text_to_image* scripts incorrectly passed a tuple with the specified resolution in both width and height, which causes TorchVision resize transform to resize directly to the target size instead of properly preserving the aspect ratio.
This would have also caused the subsequent CenterCrop transform to be redundant.
https://pytorch.org/vision/main/generated/torchvision.transforms.functional.resize.html