[Dtype] Align dtype casting behavior with Transformers and Accelerate #1725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
changed the title
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
This pretty much reverses: #1449 |
Contributor
Author
|
Wait until huggingface/accelerate#920 is merged. |
patrickvonplaten
changed the title
patrickvonplaten
changed the title
Contributor
Author
|
@pcuenca @patil-suraj feel free to merge whenever. Maybe a nice message here explaining what changed would make sense as well |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…huggingface#1725) * [Dtype] Align automatic dtype * up * up * fix * re-add accelerate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some recent changes in
transformers: huggingface/transformers#20602 andaccelerate: huggingface/accelerate#920 that force us to also align the behavior indiffusers. For more information also have a look at: https://discuss.pytorch.org/t/discrepancy-between-loading-models-with-meta-tensors-and-normal-load-from-state-dict/168295