Nightly integration tests #1664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
anton-l
requested review from
patil-suraj,
patrickvonplaten,
pcuenca and
williamberman
anton-l
commented
Dec 16, 2022
| @slow | ||
| @require_torch_gpu | ||
| class StableDiffusionImg2ImgPipelineIntegrationTests(unittest.TestCase): | ||
| class StableDiffusionImg2ImgPipelineSlowTests(unittest.TestCase): |
Member
Author
There was a problem hiding this comment.
Img2Img is the most flaky, max_diff > 1e-4 even with 3 steps. If I won't find the cause today, will raise the tolerances
Contributor
There was a problem hiding this comment.
Sounds good 1e-3 is totally fine. FYI in transformers we only have 5e-3 for some one-forward pass tests
patrickvonplaten
approved these changes
Dec 16, 2022
Contributor
patrickvonplaten
left a comment
patrickvonplaten
left a comment
There was a problem hiding this comment.
Super cool! Looks all good to me :-)
Also definitely enough to start with stable diffusion for now and then maybe open some issue for things that should changed after :-)
Co-authored-by: Patrick von Platen <[email protected]>
Co-authored-by: Patrick von Platen <[email protected]>
pcuenca
approved these changes
Dec 16, 2022
Member
pcuenca
left a comment
pcuenca
left a comment
There was a problem hiding this comment.
Looking great! Just fixed a typo in the comment for RUN_NIGHTLY
Co-authored-by: Pedro Cuenca <[email protected]>
sliard
pushed a commit
to sliard/diffusers
that referenced
this pull request
Dec 21, 2022
* [WIP] Nightly integration tests * initial SD tests * update SD slow tests * style * repaint * ImageVariations * style * finish imgvar * img2img tests * debug * inpaint 1.5 * inpaint legacy * torch isn't happy about deterministic ops * allclose -> max diff for shorter logs * add SD2 * debug * Update tests/pipelines/stable_diffusion_2/test_stable_diffusion.py Co-authored-by: Patrick von Platen <[email protected]> * Update tests/pipelines/stable_diffusion/test_stable_diffusion.py Co-authored-by: Patrick von Platen <[email protected]> * fix refs * Update src/diffusers/utils/testing_utils.py Co-authored-by: Pedro Cuenca <[email protected]> * fix refs * remove debug Co-authored-by: Patrick von Platen <[email protected]> Co-authored-by: Pedro Cuenca <[email protected]>
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* [WIP] Nightly integration tests * initial SD tests * update SD slow tests * style * repaint * ImageVariations * style * finish imgvar * img2img tests * debug * inpaint 1.5 * inpaint legacy * torch isn't happy about deterministic ops * allclose -> max diff for shorter logs * add SD2 * debug * Update tests/pipelines/stable_diffusion_2/test_stable_diffusion.py Co-authored-by: Patrick von Platen <[email protected]> * Update tests/pipelines/stable_diffusion/test_stable_diffusion.py Co-authored-by: Patrick von Platen <[email protected]> * fix refs * Update src/diffusers/utils/testing_utils.py Co-authored-by: Pedro Cuenca <[email protected]> * fix refs * remove debug Co-authored-by: Patrick von Platen <[email protected]> Co-authored-by: Pedro Cuenca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to speed up our
slow/pushtests, this PR:@nightlydecorator for tests that can be enabled withRUN_NIGHTLY=1num_inference_steps=3for all@slowtests@slowtests to@nightlynum_inference_steps~50for all@nightlytestsNightly tests will be run daily at midnight by our CI.