Skip to content

Conversation

@anton-l
Copy link
Member

@anton-l anton-l commented Nov 17, 2022

make fix-copies didn't copy the function signature

@anton-l
Copy link
Member Author

anton-l commented Nov 17, 2022

Merging to fix the fast tests

@anton-l anton-l merged commit 61719bf into main Nov 17, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 17, 2022

The documentation is not available anymore as the PR was closed or merged.

@anton-l anton-l deleted the fix-gpu-id branch November 17, 2022 14:54
@patrickvonplaten
Copy link
Contributor

@anton-l I think we have the following problem now, we have to run make fix-copies multiple times if this are copied from things that are copied from 😅 => Can we maybe slightly change make fix-copies to just run as long as differences are still detected as an easy quick fix? It really doesn't take long too run so think that'd be nice :-)

@anton-l
Copy link
Member Author

anton-l commented Nov 17, 2022

@patrickvonplaten ah, just noticed what happened here. I don't think we should do multiple runs of fix-copies, we should copy from the original source instead. Otherwise if we're not careful that might lead to circular copies and an endless fix-copies loop. Opening another PR to correct the AltDiffusionPipeline copy statements which were caused by another bug in fix-copies

@anton-l anton-l mentioned this pull request Nov 17, 2022
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants