[Low cpu memory] Correct naming and improve default usage #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
patrickvonplaten
changed the title
patrickvonplaten
commented
Nov 3, 2022
patrickvonplaten
commented
Nov 3, 2022
patil-suraj
approved these changes
Nov 3, 2022
Contributor
patil-suraj
left a comment
patil-suraj
left a comment
There was a problem hiding this comment.
Looks good, thanks for fixing this!
Co-authored-by: Suraj Patil <[email protected]>
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…e#1122) * correct naming * finish * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Suraj Patil <[email protected]> Co-authored-by: Suraj Patil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the naming to the same we have in Transformers and additionally:
low_cpu_mem_usage=Trueif PyTorch < 1.9 is installed => we raise an Errorlow_cpu_mem_usage=Falsebutdevice_map=True