Allow saving None pipeline components
#1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-l
commented
Nov 3, 2022
Comment on lines
+322
to
+324
| # check that there's no error when saving a pipeline with one of the models being None | ||
| with tempfile.TemporaryDirectory() as tmpdirname: | ||
| pipe.save_pretrained(tmpdirname) |
Member
Author
There was a problem hiding this comment.
Testing that the error is gone
|
The documentation is not available anymore as the PR was closed or merged. |
patil-suraj
approved these changes
Nov 3, 2022
Contributor
patil-suraj
left a comment
patil-suraj
left a comment
There was a problem hiding this comment.
Great catch, thanks for fixing this!
pcuenca
approved these changes
Nov 3, 2022
Member
pcuenca
left a comment
pcuenca
left a comment
There was a problem hiding this comment.
Very cool! I've seen a few reports from people that are possibly experiencing this!
Contributor
patrickvonplaten
left a comment
patrickvonplaten
left a comment
There was a problem hiding this comment.
Thanks a lot! Could you quickly do the same changes for Flax 😅
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* Allow saving `None` pipeline components * support flax as well * style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error when trying to save SD pipelines with
safety_checker=None