Fix tests for equivalence of DDIM and DDPM pipelines #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgrigory
changed the title
anton-l
approved these changes
Nov 2, 2022
Member
There was a problem hiding this comment.
Thank you @sgrigory! I've now realized that in my attempt to reproduce your solution I passed use_clipped_model_output incorrectly through the pipeline and it didn't affect the scheduler 😅 It works now!
Gentle ping @patrickvonplaten, as it's a scheduler change
patrickvonplaten
approved these changes
Nov 2, 2022
Contributor
patrickvonplaten
left a comment
patrickvonplaten
left a comment
There was a problem hiding this comment.
Very cool! Thanks a mille @sgrigory
PhaneeshB
pushed a commit
to nod-ai/diffusers
that referenced
this pull request
Mar 1, 2023
Signed-off-by: Gaurav Shukla <[email protected]>
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* Fix equality test for ddim and ddpm * add docs for use_clipped_model_output in DDIM * fix inline comment * reorder imports in test_pipelines.py * Ignore use_clipped_model_output if scheduler doesn't take it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #553
DDIM and DDPM pipelines are equivalent only if
DDIMscheduler is called withuse_clipped_model_output=True. Currently it's not possible to pass this argument from the pipeline, and sotest_ddpm_ddim_equality_batchedwas failing. The unbatched versiontest_ddpm_ddim_equalitywas also failing if one changed the random seed (e.g. to 4), as described in the issue.This PR:
use_clipped_model_outputfrom DDIM pipeline to the scheduleruse_clipped_model_output=Trueintest_ddpm_ddim_equality_batchedandtest_ddpm_ddim_equalityAs a result, both tests are passing (each runs for 2 values of the seed)
