fixing tests for numpy and make deterministic (ddpm) #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
Okay, @patrickvonplaten this should be fine to merge. As long as we are okay with scheduler tests starting in PyTorch, which is a little bit easier to work with given the random sampling of some schedulers and current API. |
natolambert
changed the title
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* work in progress, fixing tests for numpy and make deterministic * make tests pass via pytorch * make pytorch == numpy test cleaner * change default tensor format pndm --> pt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @patrickvonplaten. Will let you know if I fix this before bed today. Numpy not having a generator makes this tricky.
Some easy fixes are in this, such as
get_varianceinDDPMTesterClassneeds to be changed to_get_variance(what should the common terminology on this be)Then this change also broke the
ve sde testfor the full loop, which is very sensitive to changes inrandn_like. This is a common problem for these tests.