Inconsistent behavior of loading .safetensors models when setting use_safetensors=True

[arthur-x]

Describe the bug

The use of function StableDiffusionPipeline.from_ckpt is not consistent with the document w.r.t. loading .safetensors models. Specifically, calling this function to load a .safetensors model and in the same time setting use_safetensors=True will result in a ValueError saying safetensors is not installed. Despite already having a safetensors installation.

Related PR:

#3333 discussed about safetensors' doc, but didn't mention the bug, nor did it fix the bug.

Suspected Cause:

Line 1243 in src/diffusers/loaders.py gets the parameter:

use_safetensors = kwargs.pop("use_safetensors", None if is_safetensors_available() else False)

If we set use_safetensors=True, then after this, use_safetensors will be True regardless of is_safetensors_available().

Then at line 1249 we call:

if from_safetensors and use_safetensors is True:
        raise ValueError("Make sure to install `safetensors` with `pip install safetensors`.")

Thus if we have a .safetensors file (which means from_safetensors == True) this throws a ValueError.

Reproduction

from diffusers import StableDiffusionPipeline
pipe = StableDiffusionPipeline.from_ckpt("/path/to/model.safetensors", use_safetensors=True)

Gives:

...
ValueError: Make sure to install `safetensors` with `pip install safetensors`.

Logs

No response

System Info

Colab, latest diffusers

[Zundrium]

Thanks, this was driving me crazy.

[patrickvonplaten]

@sayakpaul do you maybe have time to look into this?

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

[arthur-x]

doesn't look like fixed.

[JemiloII]

i don't like the safetensors format. Most of these safetensors don't load correctly in code and you don't get to know the format. It would have been nice if the safetensors would save like model.pt.safetensors or model.ckpt.safetensors. but it seems you have whatever format you want.

[sayakpaul]

Gently pinging @patrickvonplaten

[patrickvonplaten]

Think this is fixed with #3466 no? Can you double check?

[arthur-x]

I tried the current main branch version on github. While I am encountering the same issue as in #3466 right now (diffusers trying to treat a local path as url), I read the code and think the inconsistent behavior regarding use_safetensors=True should have been fixed in the main branch.

Again I am unable to verify for sure but it looks okay.

[sayakpaul]

Okay. Closing this issue thread for now. Feel free to reopen.