Skip to content

Update log to use kv_unstable_std instead of std #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Jan 11, 2021

Part of rust-lang/log#437

The log crate has an unstable structured logging API under the kv_unstable feature. In previous releases, if you specified both the kv_unstable and std features of log like so:

log = { features = ["std", "kv_unstable"]}

you'd get support for standard library types in log's structured logging API.

Going forward, this functionality is now gated under kv_unstable_std:

log = { features = ["kv_unstable_std"]}

This change was made because we need to enable features in optional dependencies when both the std and kv_unstable features are enabled, which isn't currently supported by Cargo.

This PR updates this library to follow the new approach. It can be merged at any time and is currently non-blocking, but on 2020-01-18 the version of log requiring kv_unstable_std instead of kv_unstable and std will be published.

Thanks for trying out log's structured logging API and sorry for any disruption! 🙇

@KodrAus KodrAus mentioned this pull request Jan 11, 2021
21 tasks
@jbr
Copy link
Member

jbr commented Jan 27, 2021

i believe this closes #787

@jbr jbr linked an issue Jan 27, 2021 that may be closed by this pull request
@KodrAus
Copy link
Contributor Author

KodrAus commented Jan 27, 2021

It should, yes 👍

It was unfortunate to have to break but I’m trying to avoid any more until we can stabilize the API proper.

@pepoviola pepoviola requested a review from yoshuawuyts January 27, 2021 23:29
@pepoviola
Copy link
Contributor

Hi @KodrAus, thanks for the pr! I just resolve the conflict. ping @yoshuawuyts I think is ready to merge :)
Thx!

@yoshuawuyts yoshuawuyts merged commit 9365b5b into http-rs:main Jan 28, 2021
@yoshuawuyts
Copy link
Member

Fixed in v0.15.1. Release notes: https://github.com/http-rs/tide/releases/tag/v0.15.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example code won't build with log = "0.4.14"
5 participants