Split files #75
Merged
Split files #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a necessary step to enable splitting the main match statement into independent functions.
yoshuawuyts
force-pushed
the
split-files
branch
from
c87e91e to
fd3e4fd
Compare
rylev
approved these changes
Mar 26, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split server.rs and client.rs into separate encoder / decoders for each. Additionally refactored the server encoder loop from a match / break state machine into separate functions. Reviewing this patch is probably best done on a per-commit basis.
This is prep work to further drill down into our out of bound reads issues which I'm still running into. Thanks!