Skip to content

Conversation

@gsnedders
Copy link
Member

Fixes #488. Note that this still needs tests.

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2020

Codecov Report

Merging #496 into master will decrease coverage by 0.09%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
- Coverage   90.91%   90.81%   -0.10%     
==========================================
  Files          49       50       +1     
  Lines        6933     6969      +36     
  Branches     1321     1327       +6     
==========================================
+ Hits         6303     6329      +26     
- Misses        472      479       +7     
- Partials      158      161       +3     
Impacted Files Coverage Δ
html5lib/treebuilders/etree_lxml.py 79.36% <50.00%> (-0.56%) ⬇️
html5lib/tests/tree_construction.py 94.16% <0.00%> (-1.40%) ⬇️
html5lib/tests/test_sanitizer.py 94.59% <0.00%> (-0.15%) ⬇️
html5lib/tests/test_serializer.py 93.05% <0.00%> (-0.05%) ⬇️
html5lib/tests/test_treewalkers.py 97.14% <0.00%> (-0.05%) ⬇️
html5lib/_trie/__init__.py 100.00% <0.00%> (ø)
html5lib/tests/test_encoding.py 100.00% <0.00%> (ø)
html5lib/_trie/datrie.py 74.19% <0.00%> (ø)
html5lib/tests/tokenizer.py 83.33% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e749511...beecdf4. Read the comment docs.

@gsnedders gsnedders mentioned this pull request May 28, 2020
@gsnedders gsnedders force-pushed the lxml_following_comments branch from fb68f8c to beecdf4 Compare June 9, 2020 00:58
@gsnedders gsnedders marked this pull request as ready for review June 9, 2020 01:27
@gsnedders gsnedders merged commit d49afd3 into html5lib:master Jun 9, 2020
@gsnedders gsnedders deleted the lxml_following_comments branch June 9, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lxml doesn't roundtrip comments after </html>

2 participants