Add expected failures #174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/3259 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
We can't currently add the lone-surrogates tests because the expected failures file is UTF-8 and we can't have lone-surrogates there. Le sigh…
gsnedders
force-pushed
the
expected_failures
branch
from
abbe5b8 to
e706397
Compare
Also update the expected failures now we no longer fail a test.
|
We should probably include the whole test in the XFAIL file, and include some code to practically update expectations. |
Closed
|
This is basically abandoned in lieu of the expected_failures_pytest branch in my repo, given that provides a far better basis to be able to programmatically update expectations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't quite finished: notably, we still have four failures in the tokeniser tests because we can't currently add the lone-surrogates tests because the expected failures file is UTF-8 and we can't have lone-surrogates there. Options are to have a WTF-8 codec or add some escapes to test data files (optionally just for new files, maybe?) or to just fix the tokeniser and worry about this later, I think. Suggestions?