Skip to content

Fix a tiny buffer overflow. #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2015
Merged

Fix a tiny buffer overflow. #319

merged 1 commit into from
Nov 24, 2015

Conversation

@CMB
Copy link
Contributor

@CMB CMB commented Nov 23, 2015

No description provided.

@geoffmcl geoffmcl added the Bug label Nov 24, 2015
@geoffmcl geoffmcl added this to the 5.1 milestone Nov 24, 2015
geoffmcl added a commit that referenced this pull request Nov 24, 2015
@geoffmcl
Merge pull request #319 from CMB/memfix
b8e4f6e 
Fix a tiny buffer overflow.
@geoffmcl geoffmcl merged commit b8e4f6e into htacg:master Nov 24, 2015
geoffmcl added a commit that referenced this pull request Nov 24, 2015
@geoffmcl
Issue #319 - bump to 5.1.26 for merge of buffer fix
0ef4493
@geoffmcl
Copy link
Contributor

@CMB thanks have merged it...

But was not able to use 'wget' to get the page you showed, like I usually can do...

edbrowse (in windows) did better and I got -

edbrowse https://www.indiegogo.com/projects/translation-of-the-book-play-to-live-volume-6
no ssl certificate file specified; secure connections cannot be verified
1139
warning: http error 416, Requested Range Not Satisfiable
4438
957

I did that before and after I merged but no crash here in either case, despite the obvious over-run before...

Hope you get a chance to update tidy to 5.1.26 and test again... and thanks again...

@CMB
Copy link
Contributor Author

CMB commented Nov 25, 2015 via email

@geoffmcl
Copy link
Contributor

@CMB Thanks Chris. Yes, the wget worked fine on broken.html

It turned out we just needed the line 3 <head prefix="og: http://ogp.me/ns# etc... > to test and exercise that allocation. So was able to reduce that 900 line, 150 KB file to a 12 line, 285 byte sample - http://geoffair.org/tmp/in_eb10-2.html - that exercises that particular piece of allocation code, now fixed.

I suppose I could add that sample to our test cases, as a RDFa sample, and one that exercises at least the prefix attribute. Will try to get around to that, maybe expanding it to do some more RDFa testing...

Meantime I installed valgrind in my Ubuntu, and ran tidy 5.1.26 on my in_eb10-2.html file, and it reported 0 errors, compared to an invalid write of size 1 for tidy 5.1.25, so I hope all fixed. Thanks again...

@geoffmcl geoffmcl mentioned this pull request Jan 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

2 participants

@CMB @geoffmcl