/usr/bin/ld: cannot find -ltidy

[skynet]

Installed tidy-html5:

git clone https://github.com/htacg/tidy-html5.git
cd tidy-html5
cd build/cmake
cmake ../.. -DBUILD_SHARED_LIB:BOOL=ON
make
make install

Building php-5.6.7 from source I get this:

/usr/bin/ld: cannot find -ltidy
collect2: error: ld returned 1 exit status
make: *** [libphp5.la] Error 1

Am I missing something here?

I used to do:

git clone https://github.com/ermshiperete/tidy-html5.git
cd tidy-html5
sh build/gnuauto/setup.sh
./configure
make
make install

which actually worked.

[geoffmcl]

@skynet, well at this point we are generating a libtidy5.so.4.9.23, aka -ltidy5, so an install of this version will not clobber any existing tidy install, so comparisons can be made...

This will only be changed to 'libtidy.so...', aka -ltidy on the eventual release of tidy 5.0.0. In preparation for this name change I have just pushed a modified CMakeLists.txt using a macro for the name, like set(LIB_NAME tidy5). So do another pull...

Taking a quick look in php-5.6.7 configure I can see (a) it seems to support both the static and shared libtidy, and (b) for sure it is searching for 'tidy', as it should, NOT 'tidy5'. Not sure how you could change that to seeking 'tidy5'... but there would be a way...

But if you want to test compile with php as is, then just change the name in line 5 of CMakeLists.txt to set(LIB_NAME tidy), and recompile, install...

Hope this helps, and look forward to your report of success.

[anEffingChamp]

On my system I made a soft link from tidy to tidy5. That is not a repo
based solution, but it works.

[geoffmcl]

@anEffingChamp thanks for that quick tip! Being mainly a 'windows' person I would never have thought of that ;=))

I took a look in my Ubuntu 14.04 and noted that the previous version of tidy installed is libtidy-0.99.so.0.0.0, and then there are 2 links -

1. libtidy.so -> libtidy-0.99.so.0.0.0
2. libtidy-0.99.so.0 -> libtidy-0.99.so.0.0.0

And my new version is libtidy5.so.4.9.23, also with two links

1. libtidy5.so -> libtidy5.so.4.9.23
2. libtidy5.so.4 -> libtidy5.so.4.9.23

So what, I delete the 2 current libtidy links, and then just do -

1. sudo ln -s libtidy5.so.4.9.23 libtidy.so
2. sudo ln -s libtidy5.so.4.9.23 libtidy.so.4

Is that it? Or have I got that in reverse? And maybe I do not need to do the deletes?

And I also have 2 static libraries there, libtidy.a and libtidy5.a. Should I do anything about them?

Sorry for all the questions on linux things...

[anEffingChamp]

Based on the thread it sounds like we may just be looking for the compiled binary under the wrong name. sudo ln -s tidy5 tidy should link the names such that invoking tidy will call the binary under its current name. If we are looking for ltidy then you do the same thing wherever ltidy should reside. Just remember to execute this command in your /etc, or wherever you keep your binaries.

[geoffmcl]

@anEffingChamp, certainly in the @skynet case of building php from source, I think the automake tools are looking for the tidy library, not the console binary...

And interestingly, in another project, that uses cmake, added a FindTIDY.cmake module I wrote, then do find_package(TIDY), and it seems IF I leave the static libtidy.a installed, this is found first, and thus I end up linking with the static library. Not a particularly bad thing, but...

Only if I DELETED the installed static library, would it find the libtidy.so!

Still to try the change-in-the-link thingy... and thanks for the pointer that ln can also be used to run console tidy5 using just tidy... in my case such binaries are in either /usr/bin or /usr/local/bin, or in my own private $HOME/bin, all of which are in my PATH environment variable...

And remember if you want to check EXACTLY what is being used in the compile and link add the option -DCMAKE_VERBOSE_MAKEFILE=ON, and all is revealed ;=))

[geoffmcl]

Reading around more on this shared versus static libraries, we could build, and thus install, BOTH at the same time, BUT for windows at least such libraries have to have different names, like tidy_static.lib, and tidy.lib/tidy.dll for shared pair (DLL).

Some other examples I have seem are just adding an 's' for static, tidys.lib. Others choose to change the archive name of the shared pair, like tidy_imp.lib/tidy.dll. And there are probably many other choices...

And although in unix they CAN have the same base name, since one would be libtidy.a, and the other libtidy.so, the above exploration, and reading, shows libtidy.a is likely to be found first, although I have read others think this is the opposite! So also using libtidy_static.a, or libtidys.lib seems a better, clearer choice.

Anyway, this is just a thought a little off topic... for discussion... ATM CMakeLists.txt builds only one or the other, and contains an option -DBUILD_SHARED_LIB:BOOL=[ON|OFF]. The present default is OFF.

[skynet]

Can we still make it easy and ubiquitous to install tidy-html5 with php? I can also see some old PECL package: https://pecl.php.net/package/tidy. How about a new https://pecl.php.net/package/tidy-html5

[skynet]

@geoffmcl

Changed the name in line 5 of CMakeLists.txt to set(LIB_NAME tidy) Recompiled, installed. When compiling php still getting an error:

/usr/bin/ld: /usr/local/lib/libtidy.a(alloc.c.o): relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC
/usr/local/lib/libtidy.a: could not read symbols: Bad value
collect2: error: ld returned 1 exit status
make: *** [libphp5.la] Error 1

[skynet]

I ended up configuring PHP without tidy-html5. I also wonder if anyone can actually compile php with it. We should make this possible again.

[geoffmcl]

@skynet as mentioned earlier it seems if you have BOTH the static libtidy.a AND the shared libtidy.so INSTALLED then I found many tools tend to find the static version first...

And your errors indicate it found and tries to use /usr/local/lib/libtidy.a, the STATIC library. Maybe just deleting this, and it has a chance to find the installed SHARED libtidy.so...

Which PHP source are you using? If you point me to the source maybe I can download and try a compile... I agree we should be able to compile PHP with tidy5 support...