forked from swiftlang/swift-docc-render
-
Notifications
You must be signed in to change notification settings - Fork 0
Remove Technology list from the ribbon to use badges #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mportiz08
merged 10 commits into
hqhuang/remove-right-side-bar
from
update-technology-list
Mar 15, 2022
Merged
Remove Technology list from the ribbon to use badges #8
mportiz08
merged 10 commits into
hqhuang/remove-right-side-bar
from
update-technology-list
Mar 15, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use badge for technology list
fix badge color/spacing and logic to hide tech list
Remove`TechnologyList` and fix tests
Remove unnecessary styling
mportiz08
reviewed
Mar 14, 2022
mportiz08
reviewed
Mar 14, 2022
Address PR feedback
mportiz08
reviewed
Mar 15, 2022
Move style to `Availability`
Add || [] check for platforms
mportiz08
approved these changes
Mar 15, 2022
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 88214559, 88214559
Summary
Move the technology list from the ribbon to inside the Hero/Introduction section in badges
Only show technology list if page belongs to/require multiple technologies or if name doesn't match root of page