Skip to content

Fix body content spacing when there is a sidebar #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2022
Merged

Fix body content spacing when there is a sidebar #2

merged 1 commit into from
Mar 3, 2022

Conversation

@hqhhuang
Copy link
Owner

@hqhhuang hqhhuang commented Mar 3, 2022

Bug/issue #, if applicable: 89650008, 89650141

Summary

Fixing the missing padding between the topic sections when a sidebar is present.

Before:

Screen Shot 2022-03-03 at 9 51 48 AM

After:

Screen Shot 2022-03-03 at 9 53 53 AM

Testing

Steps:

  1. Run swift-docc-render with a docc-archive.
  2. Verify that padding-bottom is 40px (between the last section and the footer and between each sections)

Checklist

  • Added tests - NA
  • Ran npm test, and it succeeded
  • Updated documentation if necessary - NA

@hqhhuang
fix content spacing with sidebar
773e7be 
fix content spacing with sidebar
@marinaaisa marinaaisa self-requested a review March 3, 2022 18:10
@hqhhuang hqhhuang merged commit 0fad744 into hqhuang/remove-right-side-bar Mar 3, 2022
@hqhhuang hqhhuang deleted the fix-spacing-with-sidebar branch March 3, 2022 18:16
hqhhuang added a commit that referenced this pull request Mar 3, 2022
@hqhhuang
Squashed commit of the following:
095ac45 
commit 882f7a3
Author: Hanqing Huang <[email protected]>
Date:   Thu Mar 3 15:16:11 2022 -0800

    Update check-source

commit f7ce4c6
Author: Hanqing Huang <[email protected]>
Date:   Thu Mar 3 15:15:09 2022 -0800

    Update check-source

commit 623564b
Merge: 3f83bef 0fad744
Author: Hanqing Huang <[email protected]>
Date:   Thu Mar 3 15:01:37 2022 -0800

    Merge branch 'hqhuang/remove-right-side-bar' of github.com:hqhhuang/swift-docc-render into hqhuang/remove-right-side-bar

commit 3f83bef
Author: Hanqing Huang <[email protected]>
Date:   Thu Mar 3 14:54:16 2022 -0800

    squash style change

commit 0fad744
Merge: e3e7c1a 773e7be
Author: Hanqing Huang <[email protected]>
Date:   Thu Mar 3 10:16:03 2022 -0800

    Merge pull request #2 from hqhhuang/fix-spacing-with-sidebar

    Fix body content spacing when there is a sidebar

commit 773e7be
Author: Hanqing Huang <[email protected]>
Date:   Thu Mar 3 09:42:54 2022 -0800

    fix content spacing with sidebar

    fix content spacing with sidebar

commit e3e7c1a
Merge: d7befa0 5298f23
Author: Hanqing Huang <[email protected]>
Date:   Wed Mar 2 21:46:39 2022 -0800

    Merge remote-tracking branch 'dobri/dhristov/add-sidenav-hero-v2' into hqhuang/remove-right-side-bar

commit d7befa0
Merge: 88cd1f4 914871d
Author: Hanqing Huang <[email protected]>
Date:   Wed Mar 2 21:20:10 2022 -0800

    Merge remote-tracking branch 'upstream/main' into hqhuang/remove-right-side-bar

commit 88cd1f4
Merge: 3c21d07 527827c
Author: Hanqing Huang <[email protected]>
Date:   Tue Feb 22 10:49:11 2022 -0800

    Merge remote-tracking branch 'upstream/main' into hqhuang/remove-right-side-bar

commit 3c21d07
Merge: ada1313 cf0b5f7
Author: Hanqing Huang <[email protected]>
Date:   Mon Feb 21 09:30:40 2022 -0800

    Merge branch 'dhristov/add-sidenav-hero' into hqhuang/remove-right-side-bar

commit cf0b5f7
Author: Marina Aísa <[email protected]>
Date:   Mon Feb 21 18:29:25 2022 +0100

    fix: conflicts

commit ada1313
Merge: c3664b8 cd3cca0
Author: Hanqing Huang <[email protected]>
Date:   Mon Feb 21 09:19:50 2022 -0800

    Merge branch 'dhristov/add-sidenav-hero' into hqhuang/remove-right-side-bar

commit cd3cca0
Merge: 5135587 790efff
Author: Marina Aísa <[email protected]>
Date:   Mon Feb 21 18:09:32 2022 +0100

    Merge remote-tracking branch 'upstream/main' into dhristov/add-sidenav-hero

commit c3664b8
Author: Hanqing Huang <[email protected]>
Date:   Mon Feb 21 00:52:51 2022 -0800

    fix import for throttle - 2

    fix import for throttle - 2

commit 802f4ff
Author: Hanqing Huang <[email protected]>
Date:   Mon Feb 21 00:48:27 2022 -0800

    fix import for throttle

    fix import for throttle

commit 5135587
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 18 13:36:34 2022 +0200

    fix: add dynamic-content-container mixin to the DocumentationHero

commit 4162531
Merge: 6bf0711 e522b1f
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 18 13:34:56 2022 +0200

    Merge branch 'dhristov/add-sidenav' into dhristov/add-sidenav-hero

    # Conflicts:
    #	src/components/DocumentationTopic/Title.vue

commit e522b1f
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 18 12:21:07 2022 +0200

    feat: update the content breakpoints, to have an xlarge value, applying extra padding to the dynamic content mixin

commit d58f443
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 18 11:00:38 2022 +0200

    fix: make sure container styling properly falls back to none-dynamic content styling

commit f78df87
Author: Hanqing Huang <[email protected]>
Date:   Fri Feb 18 00:56:02 2022 -0800

    Fix no overview bug

    Fix no overview bug

commit 6ae1032
Merge: 10bc106 9601c06
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 18 08:35:21 2022 +0200

    Merge pull request #5 from mportiz08/sidenav-feature-flag

    Hide new navigator UX behind a feature flag

commit 9601c06
Author: Marcus Ortiz <[email protected]>
Date:   Thu Feb 17 15:50:29 2022 -0800

    Fix import.

commit fdae435
Author: Marcus Ortiz <[email protected]>
Date:   Thu Feb 17 15:26:38 2022 -0800

    Fix broken tests.

commit e15e47d
Author: Marcus Ortiz <[email protected]>
Date:   Thu Feb 17 14:56:06 2022 -0800

    Add theme-setting feature flag for navigator.

commit aadb0a5
Author: Marcus Ortiz <[email protected]>
Date:   Thu Feb 17 14:45:17 2022 -0800

    Add `enableNavigator` prop.

    This will act as a feature flag to enable the new sidebar/navigator UX.

commit 255494e
Author: Hanqing Huang <[email protected]>
Date:   Thu Feb 17 11:23:37 2022 -0800

    Fix header spacing for failing tests

    Fix header spacing for failing tests

commit 51ce3be
Author: Hanqing Huang <[email protected]>
Date:   Thu Feb 17 11:11:47 2022 -0800

    Font, padding, border radius changes

    Font, padding, border radius changes

commit 2e75537
Author: Hanqing Huang <[email protected]>
Date:   Thu Feb 17 10:50:09 2022 -0800

    Address Marina's PR feedback

    Address Marina's PR feedback

commit 7d157be
Author: Hanqing Huang <[email protected]>
Date:   Thu Feb 17 10:21:38 2022 -0800

    Address PR feedback: mobile view, spacings

    Address PR feedback: mobile view, spacings

commit 76d6537
Author: Hanqing Huang <[email protected]>
Date:   Wed Feb 16 14:17:31 2022 -0800

    Topics Section and Ribbon Style Change

    Topics Section and Ribbon Style Change & Fix test.

commit 22a91a3
Author: Hanqing Huang <[email protected]>
Date:   Tue Feb 15 22:19:10 2022 -0800

    Remove right side bar; add availability

    Remove right side bar; add availability

commit 6bf0711
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 17 19:41:45 2022 +0200

    Revert "refactor: remove the DocumentationHero from DocumentationTopic"

    This reverts commit 10bc106

commit 10bc106
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 17 13:24:31 2022 +0200

    refactor: remove the DocumentationHero from DocumentationTopic

commit 06ae412
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 17 17:52:02 2022 +0200

    Update src/components/Navigator/HighlightMatches.vue

    Co-authored-by: Marina Aísa <[email protected]>

commit 0a4bd48
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 17 17:51:10 2022 +0200

    fix: copy year

commit 8352daf
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 17 15:28:34 2022 +0200

    chore: change copyright year in header for new files

commit d528929
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 17 15:11:28 2022 +0200

    fix: make sure we only use persisted values, if all of the UIDs match what is currently available

commit b5710af
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 17 15:01:28 2022 +0200

    fix: scroll locking on iOS for AdjustableSidebarWidth

commit 176c9b2
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 17 14:04:57 2022 +0200

    refactor: make sure toggle button has a wider trigger area

commit 115ce02
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 17 11:22:17 2022 +0200

    chore: add more explanation to Hierarchy changes

commit 995b58c
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 17 10:14:15 2022 +0200

    fix: update check-source to accept 2022

commit 5fee7cd
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 17 10:01:26 2022 +0200

    refactor: updates from PR reviews

commit 6643384
Author: Dobromir Hristov <[email protected]>
Date:   Wed Feb 16 10:46:00 2022 +0200

    refactor: update types

commit 5ac0e58
Author: Dobromir Hristov <[email protected]>
Date:   Wed Feb 16 10:16:14 2022 +0200

    chore: revert change to --color-nav-hierarchy-collapse-background

commit 4949537
Author: Dobromir Hristov <[email protected]>
Date:   Wed Feb 16 10:10:06 2022 +0200

    fix: increase the tree-toggle size a bit more

commit 02b7561
Author: Dobromir Hristov <[email protected]>
Date:   Wed Feb 16 09:52:01 2022 +0200

    fix: unable to drag scrollbar

commit 6a4253b
Author: Dobromir Hristov <[email protected]>
Date:   Tue Feb 15 15:40:29 2022 +0200

    chore: add tests

commit 6f6f8d8
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 4 10:38:42 2022 +0200

    refactor: small changes to hierarchy toggle colors

commit 2549eec
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 4 10:02:44 2022 +0200

    refactor: reduce items to show, if has badge

commit a09bf18
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 3 13:48:05 2022 +0200

    refactor: Hierarchy.vue component to show more items at once

commit 3613a7c
Author: Dobromir Hristov <[email protected]>
Date:   Wed Feb 2 10:52:12 2022 +0200

    refactor: extract nav wide padding

commit add0382
Author: Dobromir Hristov <[email protected]>
Date:   Tue Feb 1 11:28:28 2022 +0200

    fix: update the font style for nav toggles

commit 23c9cc6
Author: Dobromir Hristov <[email protected]>
Date:   Fri Jan 21 15:57:08 2022 +0200

    feat: introduce wide-format boolean to the NavBase

commit ed28ee7
Author: Dobromir Hristov <[email protected]>
Date:   Tue Feb 15 13:11:56 2022 +0200

    fix: bad path do TopicTypes

commit 476b668
Author: Dobromir Hristov <[email protected]>
Date:   Tue Feb 15 13:06:41 2022 +0200

    chore: add header

commit 7baf34f
Author: Dobromir Hristov <[email protected]>
Date:   Tue Feb 15 12:04:56 2022 +0200

    fix: update to new interfaceLanguage property

commit f452302
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 11 09:54:44 2022 +0200

    refactor: change kind to type, and change the navigator path

commit 1cb0b95
Author: Dobromir Hristov <[email protected]>
Date:   Tue Feb 15 11:47:21 2022 +0200

    chore: update the sidenav icon

commit fad14c0
Author: Dobromir Hristov <[email protected]>
Date:   Tue Feb 15 11:39:03 2022 +0200

    chore: update vertical card spacing on NavigatorCard.vue

commit 5cdcd62
Author: Dobromir Hristov <[email protected]>
Date:   Tue Feb 15 09:50:45 2022 +0200

    fix: set a hard height on the Navigator

commit 95f3b49
Author: Dobromir Hristov <[email protected]>
Date:   Mon Feb 14 18:53:21 2022 +0200

    chore: add tests to Navigator.vue

commit a9630fc
Author: Dobromir Hristov <[email protected]>
Date:   Mon Feb 14 14:20:49 2022 +0200

    refactor: allow opening a direct match of a filter query

commit ea544d5
Author: Dobromir Hristov <[email protected]>
Date:   Mon Feb 14 09:38:44 2022 +0200

    refactor: remove the extraInfo functionality

commit 996760f
Author: Dobromir Hristov <[email protected]>
Date:   Mon Feb 14 09:14:17 2022 +0200

    fix: issue with growing toggle

commit 05f5f87
Author: Dobromir Hristov <[email protected]>
Date:   Mon Feb 14 09:06:36 2022 +0200

    fix: fallback to using the `role`, if no symbolKind

commit fe89619
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 11 11:40:18 2022 +0200

    fix: issues with scrolling on mobile

commit 3178cda
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 11 08:30:52 2022 +0200

    refactor: update the navigator highlight and hover colors

commit 45ed7e8
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 10 14:49:43 2022 +0200

    refactor: make header a link

commit 0f31e8d
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 10 14:13:53 2022 +0200

    fix: NavigatorCard inner padding

commit 43d5b50
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 10 14:04:20 2022 +0200

    fix: tree-toggle size

commit a7ea56f
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 10 13:52:32 2022 +0200

    fix: add animation to adjustable aside contents

commit 82fef42
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 10 13:36:21 2022 +0200

    refactor: make the DocumentationHero vertical padding uniform

commit 603176d
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 10 13:25:42 2022 +0200

    feat: add dark variant for the fill-light-blue color

commit 930427f
Author: Dobromir Hristov <[email protected]>
Date:   Wed Feb 9 11:06:19 2022 +0200

    refactor: hero colors

commit d20a72f
Author: Dobromir Hristov <[email protected]>
Date:   Wed Feb 9 11:31:36 2022 +0200

    refactor: cleanup the navigator spacing and colors

commit 52cd940
Author: Dobromir Hristov <[email protected]>
Date:   Wed Feb 9 09:50:11 2022 +0200

    chore: replace icons

commit 70b3eb5
Author: Dobromir Hristov <[email protected]>
Date:   Tue Feb 8 18:49:23 2022 +0200

    chore: add tests

commit 5fb281d
Author: Dobromir Hristov <[email protected]>
Date:   Tue Feb 8 11:02:03 2022 +0200

    refactor: replace topic icons

commit 49c083d
Author: Dobromir Hristov <[email protected]>
Date:   Mon Feb 7 20:26:26 2022 +0200

    fix: icon opacity

commit 00ed788
Author: Dobromir Hristov <[email protected]>
Date:   Mon Feb 7 18:24:23 2022 +0200

    fix: minor API changes fix

commit 71905fb
Author: Dobromir Hristov <[email protected]>
Date:   Mon Feb 7 17:16:47 2022 +0200

    chore: fix merge conflicts and flaky tests

commit 1b77aaa
Merge: 9bf1d14 44edd61
Author: Dobromir Hristov <[email protected]>
Date:   Mon Feb 7 17:11:36 2022 +0200

    Merge branch 'main' into dhristov/add-sidenav

commit 9bf1d14
Author: Dobromir Hristov <[email protected]>
Date:   Mon Feb 7 12:17:39 2022 +0200

    fix: remove flashing when going from Medium to Small

commit b1b7a79
Author: Dobromir Hristov <[email protected]>
Date:   Mon Feb 7 11:49:24 2022 +0200

    chore: fix minor lint issues

commit 80bc937
Author: Dobromir Hristov <[email protected]>
Date:   Mon Dec 20 19:08:24 2021 +0200

    refactor: implement new design for Hero

commit 5b3f8b2
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 4 19:08:30 2022 +0200

    fix: add responsive constraints on AdjustableSidebarWidth

commit 764bdfb
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 4 15:22:42 2022 +0200

    chore: cleanup + tests

commit d7dd547
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 4 14:38:35 2022 +0200

    chore: add tests to AdjustableSidebarWidth

commit 84129e9
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 4 12:17:11 2022 +0200

    fix: navigator width issues when resizing/rotating device

commit 36014fc
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 4 11:29:45 2022 +0200

    fix: close the mobile sidenav, if clicking esc or on route change (going back or clicking on item)

commit 88d2a82
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 4 11:21:31 2022 +0200

    refactor: make sure navigator works, even if request errors out

commit a385af1
Merge: 62a1ff2 268befc
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 4 11:04:10 2022 +0200

    Merge branch 'dhristov/sidenav-move-sidenav-to-view' into dhristov/add-sidenav

commit 62a1ff2
Author: Dobromir Hristov <[email protected]>
Date:   Fri Feb 4 09:39:04 2022 +0200

    fix: make sure icon does not shrink

commit 4444ecc
Author: Dobromir Hristov <[email protected]>
Date:   Thu Feb 3 14:08:58 2022 +0200

    refactor: make icons more square

commit f21226f
Author: Dobromir Hristov <[email protected]>
Date:   Tue Feb 1 13:00:50 2022 +0200

    fix: make navigatoricons colors optional

commit 268befc
Merge: 4cebef8 6047c05
Author: Dobromir Hristov <[email protected]>
Date:   Tue Feb 1 12:53:31 2022 +0200

    Merge branch 'dhristov/add-sidenav' into dhristov/sidenav-move-sidenav-to-view

commit 4cebef8
Author: Dobromir Hristov <[email protected]>
Date:   Tue Feb 1 12:44:31 2022 +0200

    fix: issues with apiChangesObserving

commit 6047c05
Author: Dobromir Hristov <[email protected]>
Date:   Mon Jan 31 15:32:41 2022 +0200

    fix: make sure regex matcher works as expected

commit a7a2f11
Author: Dobromir Hristov <[email protected]>
Date:   Mon Jan 31 12:31:30 2022 +0200

    fix: safari bug with icons

commit 88571ea
Author: Dobromir Hristov <[email protected]>
Date:   Mon Jan 31 12:23:19 2022 +0200

    chore: add extra descriptions

commit 9118ae8
Author: Dobromir Hristov <[email protected]>
Date:   Wed Jan 26 14:50:55 2022 +0200

    fix: scrollToElement when persisted, and fix filtered persistence

commit 53b1359
Author: Dobromir Hristov <[email protected]>
Date:   Wed Jan 26 14:23:20 2022 +0200

    feat: persist to session storage the state of the navbar

commit 633971c
Author: Dobromir Hristov <[email protected]>
Date:   Mon Jan 31 09:36:20 2022 +0200

    chore: add extra tests to apiChangesObserving.spec.js

commit 609f4e8
Author: Dobromir Hristov <[email protected]>
Date:   Mon Jan 31 08:54:17 2022 +0200

    chore: fix tests

commit 1c3f618
Author: Dobromir Hristov <[email protected]>
Date:   Tue Jan 25 18:32:15 2022 +0200

    fix: issues with API changes on the navigation bar

commit 7d85b0a
Merge: 3902023 de67b8a
Author: Dobromir Hristov <[email protected]>
Date:   Thu Jan 27 18:49:05 2022 +0200

    Merge branch 'dhristov/add-sidenav' into dhristov/sidenav-move-sidenav-to-view

commit de67b8a
Author: Dobromir Hristov <[email protected]>
Date:   Thu Jan 27 18:47:47 2022 +0200

    fix: path

commit 3902023
Author: Dobromir Hristov <[email protected]>
Date:   Fri Jan 21 14:49:11 2022 +0200

    fix: merge conflict

commit 82ac1e7
Author: Dobromir Hristov <[email protected]>
Date:   Fri Jan 21 10:38:41 2022 +0200

    fix: add max-width

commit 95efff7
Author: Dobromir Hristov <[email protected]>
Date:   Tue Jan 18 08:31:27 2022 +0200

    refactor: move navigator and nav to the view component

commit 3b059eb
Author: Dobromir Hristov <[email protected]>
Date:   Wed Jan 26 18:45:36 2022 +0200

    feat: allow toggling the entire tree with alt + click

commit c0eeba2
Author: Dobromir Hristov <[email protected]>
Date:   Wed Jan 26 09:55:08 2022 +0200

    feat: enable groupMarkers and use default index

commit ca5b632
Author: Dobromir Hristov <[email protected]>
Date:   Wed Jan 26 09:54:45 2022 +0200

    chore: fix spacing

commit 925edf6
Author: Dobromir Hristov <[email protected]>
Date:   Mon Jan 24 10:27:23 2022 +0200

    feat: bold the current page and its parents

commit db5fb1e
Author: Dobromir Hristov <[email protected]>
Date:   Fri Jan 21 14:35:43 2022 +0200

    refactor: reduce item height

commit f71e95b
Author: Dobromir Hristov <[email protected]>
Date:   Fri Jan 21 13:00:30 2022 +0200

    refactor: styling changes to the Sidenav

commit a492305
Author: Dobromir Hristov <[email protected]>
Date:   Fri Jan 21 10:41:08 2022 +0200

    chore: add tests

commit b41f817
Author: Dobromir Hristov <[email protected]>
Date:   Wed Jan 19 18:39:39 2022 +0200

    chore: add tests

commit f95c515
Author: Dobromir Hristov <[email protected]>
Date:   Wed Jan 19 17:37:20 2022 +0200

    fix: add maxWidth to AdjustableSidebarWidth, add tests.

commit 9286a69
Author: Dobromir Hristov <[email protected]>
Date:   Tue Jan 18 10:10:49 2022 +0200

    fix: bail searches early, to save compute power

commit 64ba64d
Author: Dobromir Hristov <[email protected]>
Date:   Tue Jan 18 09:27:59 2022 +0200

    fix: properly highlight the active item. Keep open nodes across page navigation

commit 93f0d9c
Author: Dobromir Hristov <[email protected]>
Date:   Mon Jan 17 13:43:54 2022 +0200

    refactor: cleanup NavigatorCard.vue

commit 0a1840f
Author: Dobromir Hristov <[email protected]>
Date:   Mon Jan 17 13:18:46 2022 +0200

    fix: styling fixes to the sidenav

commit fa73805
Author: Dobromir Hristov <[email protected]>
Date:   Fri Jan 14 12:15:50 2022 +0200

    refactor: update the HighlightMatches component

commit 29a2602
Author: Dobromir Hristov <[email protected]>
Date:   Fri Jan 14 11:41:05 2022 +0200

    refactor: make page 100% height

commit 2ccbad6
Author: Dobromir Hristov <[email protected]>
Date:   Fri Jan 14 11:05:52 2022 +0200

    refactor: use a flat tree representation for Navigator

commit c38489f
Author: Dobromir Hristov <[email protected]>
Date:   Mon Jan 10 20:17:54 2022 +0200

    feat: add wide breakpoint support

commit 3402167
Author: Dobromir Hristov <[email protected]>
Date:   Thu Dec 23 10:37:14 2021 +0200

    feat: add the module icon

commit e4834ba
Author: Dobromir Hristov <[email protected]>
Date:   Thu Dec 23 09:36:47 2021 +0200

    refactor: fallback to glyph-gray on navigator icons

commit 20cfa90
Author: Dobromir Hristov <[email protected]>
Date:   Wed Dec 22 18:37:22 2021 +0200

    refactor: change the name of the TopicKindProps map

commit d4e2440
Author: Dobromir Hristov <[email protected]>
Date:   Wed Dec 22 15:58:33 2021 +0200

    refactor: navigator icons, colors and mapping

commit 8a489e0
Author: Dobromir Hristov <[email protected]>
Date:   Tue Dec 21 13:54:35 2021 +0200

    feat: implement icons

commit c50307b
Author: Dobromir Hristov <[email protected]>
Date:   Tue Dec 21 11:25:40 2021 +0200

    fix: introduce uid to children, so we can track expanding items

commit d940547
Author: Dobromir Hristov <[email protected]>
Date:   Tue Dec 21 11:02:39 2021 +0200

    fix: scroll to the active element in the sidebar on mount

commit 4bc8d08
Author: Dobromir Hristov <[email protected]>
Date:   Tue Dec 21 10:04:32 2021 +0200

    fix: small bugs with toggling navigator trees

commit cfa1350
Author: Dobromir Hristov <[email protected]>
Date:   Mon Dec 20 09:19:08 2021 +0200

    feat: add throttle function

commit 790f19b
Author: Dobromir Hristov <[email protected]>
Date:   Fri Dec 17 18:35:55 2021 +0200

    refactor: move the navigation-index outside of `/data`

commit fd8003e
Author: Dobromir Hristov <[email protected]>
Date:   Fri Dec 17 18:20:44 2021 +0200

    fix: add transition to filter

commit 2f46e58
Author: Dobromir Hristov <[email protected]>
Date:   Fri Dec 17 15:29:49 2021 +0200

    fix: make navigator filter stick to bottom always.

commit bbc88b5
Author: Dobromir Hristov <[email protected]>
Date:   Fri Dec 17 13:17:10 2021 +0200

    fix: import paths and technology computed

commit 763952f
Author: Dobromir Hristov <[email protected]>
Date:   Fri Dec 17 12:38:55 2021 +0200

    refactor: add basic design for navigator filter input

commit 0c30537
Author: Dobromir Hristov <[email protected]>
Date:   Fri Dec 17 11:42:15 2021 +0200

    refactor: update design to a single card sidebar. Introduce NavigatorDataProvider pattern.

commit 054fe27
Author: Dobromir Hristov <[email protected]>
Date:   Thu Dec 16 19:57:59 2021 +0200

    chore: change hex to rgb

commit 5df1bad
Author: Dobromir Hristov <[email protected]>
Date:   Thu Dec 16 15:26:27 2021 +0200

    fix: use the filter pattern to match

commit 2bf4c01
Author: Dobromir Hristov <[email protected]>
Date:   Thu Dec 16 15:19:10 2021 +0200

    feat: hide sidebar for IDE

commit 10f5ced
Author: Dobromir Hristov <[email protected]>
Date:   Thu Dec 16 15:00:09 2021 +0200

    feat: add highlighting

commit 608feb3
Author: Dobromir Hristov <[email protected]>
Date:   Thu Dec 16 14:14:28 2021 +0200

    feat: add min-width to sidebar, add touch handling

commit 66336d7
Author: Dobromir Hristov <[email protected]>
Date:   Wed Dec 15 18:50:29 2021 +0200

    feat: add extra information to the navigator, if it goes beyond a threshold

commit e2cd523
Author: Dobromir Hristov <[email protected]>
Date:   Wed Dec 15 15:06:23 2021 +0200

    feat: allow the sidebar to be toggled on/off on mobile from a button

commit a6aacb7
Author: Dobromir Hristov <[email protected]>
Date:   Wed Dec 15 13:00:42 2021 +0200

    feat: track open event on technology card

commit 1261019
Author: Dobromir Hristov <[email protected]>
Date:   Wed Dec 15 12:12:37 2021 +0200

    fix: highlighting of page, in navbar, based on breadcrumbs

commit 5fadbe7
Author: Dobromir Hristov <[email protected]>
Date:   Tue Dec 14 13:35:18 2021 +0200

    feat: add basic sidenav card and searching

commit 185aa12
Author: Dobromir Hristov <[email protected]>
Date:   Fri Dec 10 18:10:29 2021 +0200

    feat: add sidenav
@hqhhuang hqhhuang mentioned this pull request Mar 4, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marinaaisa marinaaisa marinaaisa approved these changes

@dobromir-hristov dobromir-hristov dobromir-hristov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hqhhuang @marinaaisa @dobromir-hristov