Skip to content

Conversation

@hqhhuang
Copy link
Owner

@hqhhuang hqhhuang commented Mar 29, 2022

Bug/issue #, if applicable: 90964249

Summary

Addressing PR feedback: https://github.com/dobromir-hristov/swift-docc-render/pull/3/files#r818184276
Adding margin-top and removing margin-left for the items in the Relationship Section.
Creating this new PR, since the original PR has become really large and hard to review.

Testing

See screenshot for Before and After:

Before:
Before

After:
After

Checklist

  • Added tests - NA
  • Ran npm test, and it succeeded
  • Updated documentation if necessary - NA

Add margin to relationship-list
@dobromir-hristov
Copy link
Collaborator

I am fine with the change, as long as its the intended visual effect - @SamLanier

@biamx3
Copy link

biamx3 commented Mar 29, 2022

Hi! Sam might have provided specs for this I'm not aware of, so I'll wait on her for final word.

On my end, it looks good from the screenshot. I noticed the links aren't blue though, is that intentional?

@hqhhuang
Copy link
Owner Author

Hi! Sam might have provided specs for this I'm not aware of, so I'll wait on her for final word.

On my end, it looks good from the screenshot. I noticed the links aren't blue though, is that intentional?

I didn't get spec for this. For removing the left-margin: I accidentally introduced the bug when I was working on removing the right column earlier. So this is just reverting that change.
As of the margin-top: I just made it consistent with margin-tops from other types of content (example: Topics).

@hqhhuang hqhhuang requested a review from SamLanier March 29, 2022 15:33
@SamLanier
Copy link
Collaborator

I didn't get spec for this. For removing the left-margin: I accidentally introduced the bug when I was working on removing the right column earlier. So this is just reverting that change.
As of the margin-top: I just made it consistent with margin-tops from other types of content (example: Topics).

Sounds logical to me 😊

Copy link
Collaborator

@SamLanier SamLanier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual design approved.

@hqhhuang hqhhuang merged commit 2201f46 into hqhuang/remove-right-side-bar Mar 30, 2022
@hqhhuang hqhhuang deleted the relationship-list-spacing branch March 30, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants