Skip to content

Conversation

@mportiz08
Copy link
Collaborator

Bug/issue #, if applicable: 89691924

Summary

Since the documentation hero uses a dark theme, links inside it should always use the dark theme color, regardless of the selected color scheme for the overall page.

Testing

Steps:

  1. Download/unzip example.zip
  2. Run VUE_APP_DEV_SERVER_PROXY=/path/to/unzipped/example npm run serve
  3. Open http://localhost:8080/documentation/swiftdoccrender and verify that the "DocC" link in the hero abstract always stays the same color (dark mode "figure-blue"), regardless of what setting you select in the color scheme toggle. If you select "Light", the color should differ from the color of other links on the page. If you select "Dark", the color should match the color of other links on the page.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests (CSS only change)
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

Copy link
Collaborator

@dobromir-hristov dobromir-hristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got confused about theme-dark first, but saw we are applying it on the component. Works good.

@mportiz08 mportiz08 merged commit 9c4fddc into hqhhuang:hqhuang/remove-right-side-bar Mar 23, 2022
@mportiz08 mportiz08 deleted the use-dark-theme-colors-in-hero branch March 23, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants