Add right margin to the first item in the Nav bar #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add margin right to language toggle
mportiz08
approved these changes
Mar 22, 2022
Collaborator
dobromir-hristov
left a comment
dobromir-hristov
left a comment
There was a problem hiding this comment.
This is looking good to me, just one small remark and we are good to go here.
| } | ||
| @include nav-in-breakpoint() { | ||
| &:not([data-previous-menu-children-count="0"]) { |
Collaborator
There was a problem hiding this comment.
I think this line is for the .nav-menu-settings, as data-previous-menu-children-count is applied on it.
This is basically to not apply a border-top, in case the nav is in a state, where it has no items above the setting links.
Apply CSS to correct class
dobromir-hristov
approved these changes
Mar 25, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 90568720, 88280711
Summary
Add right margin to the first item in the Nav bar
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded