Skip to content

Remove extra spacing and divider below hero #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 18, 2022
Merged

Remove extra spacing and divider below hero #12

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c99399b
remove extra spacing
hqhhuang Mar 18, 2022
ed21b8d
Remove extra divider below hero
hqhhuang Mar 18, 2022
a5b0e03
Merge branch 'remove-no-overview' into remove-extra-spacing-below-hero
hqhhuang Mar 18, 2022
8ba025f
Remove border for first section
hqhhuang Mar 18, 2022
6730067
Remove unnecessary div
hqhhuang Mar 18, 2022
2f4464b
remove comment
hqhhuang Mar 18, 2022
b080772
fix style
hqhhuang Mar 18, 2022
7a2f2bc
Fix typo.
mportiz08 Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/components/DocumentationTopic.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
:platforms="platforms" :technologies="technologies"
/>
</DocumentationHero>
<div class="container">
<div v-if="showContainer" class="container">
<div class="description">
<RequirementMetadata
v-if="isRequirement"
Expand Down Expand Up @@ -292,6 +292,17 @@ export default {
? technologyList
: [];
},
showContainer: ({
isRequirement,
deprecationSummary,
downloadNotAvailableSummary,
primaryContentSections,
}) => (
isRequirement
|| (deprecationSummary && deprecationSummary.length)
|| (downloadNotAvailableSummary && downloadNotAvailableSummary.length)
|| (primaryContentSections && primaryContentSections.length)
),
},
methods: {
normalizePath(path) {
Expand Down Expand Up @@ -356,7 +367,6 @@ export default {
}

.container {
margin-top: $section-spacing-single-side / 2;
outline-style: none;
@include dynamic-content-container;
}
Expand All @@ -373,6 +383,15 @@ export default {
}
}

// remove border-top for first section of the page
/deep/ {
.documentation-hero + .contenttable {
.container > .title {
border-top: none;
}
}
}

.sample-download {
margin-top: 20px;
}
Expand Down