Remove 'No Overview' text from Description component
#11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove 'No Overview` from Description and fix test
dobromir-hristov
requested changes
Mar 18, 2022
replace `hasOverview` with `hasDescription`
Remove `Description` component
Move over CSS from `Description` Component
hqhhuang
commented
Mar 18, 2022
fix tabbing
mportiz08
approved these changes
Mar 18, 2022
| &:empty { display: none; } | ||
| &:not(:empty) { | ||
| margin-bottom: $contenttable-spacing-single-side; |
Collaborator
There was a problem hiding this comment.
This could have been put outside the :not(:empty), because we are applying a display:none anyway :)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 'No Overview' text from
DescriptioncomponentBug/issue #, if applicable: 89691926
Summary
With the new design, if a page has no overview, we will just not display it. Thus, there's no more need for explicitly stating that a page has no overview.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded