Add Language Toggle to Nav Bar #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: Add language switcher for TargetIDE, remove hideSummary, fix test
Add `LanguageToggle` and test
fix padding-top
Collaborator
dobromir-hristov
left a comment
dobromir-hristov
left a comment
There was a problem hiding this comment.
Looking good. Left you a few small comments in there :)
tests/unit/components/DocumentationTopic/DocumentationNav.spec.js
Outdated
Show resolved
Hide resolved
Fix test and styling feedback
Add test for `menu-items` slot
dobromir-hristov
approved these changes
Mar 17, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 87851018, 88280711, 89089722, 90372549
Summary
Remove
hideSummarysince with this PR, we removed the Summary ribbon under the hero from the old design. bug: 89089722In order to view the changes on all viewports, this PR also updates the text alignment on small viewport to left-aligned (instead of center). bug: 90372549
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded