Deforestation with nofibs in the Benchmark Sub-project
#335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges to avoid creating needless matchRest functions
…new-deforest-after-lift temporarily disable the assertion in `Scope.addToBindings`
fixed missing fusion temporarily disabled an assertion in `syntax.scala`
ychenfo
commented
Sep 16, 2025
| def addToBindings(symbol: Local, name: String, shadow: Bool) = | ||
| if !shadow then assert(lookup(symbol).isEmpty, (symbol, this.showAsTree)) | ||
| // FIXME: deforestation makes this assertion fail | ||
| // if !shadow then assert(lookup(symbol).isEmpty, (symbol, this.showAsTree)) |
There was a problem hiding this comment.
I need to look into how to handle this issue, which seems to be caused by using the same Scope for generating programs both before/after deforestation?
LPTK
reviewed
Sep 19, 2025
| given Config = | ||
| if file.segments.contains("nofib-deforest") then | ||
| Config.default.copy(deforest = S(Config.Deforestation( | ||
| importedPublicModNames = Set("NofibPrelude"), |
There was a problem hiding this comment.
Suggested change
| importedPublicModNames = Set("NofibPrelude"), | |
| seethroughModules = Set("NofibPrelude"), |
LPTK
reviewed
Sep 19, 2025
| preludeFile) | ||
| deforestResult match | ||
| case Right(msg) => | ||
| println(msg) // TODO: no println |
There was a problem hiding this comment.
Suggested change
| println(msg) // TODO: no println |
LPTK
reviewed
Sep 19, 2025
| case Right(msg) => | ||
| println(msg) // TODO: no println | ||
| le | ||
| case Left(prog -> summary -> detail) => |
There was a problem hiding this comment.
Shouldn't build a summary string even when not used – use a lambda?
LPTK
reviewed
Sep 19, 2025
|
|
||
| def uid = | ||
| import Result.* | ||
| val uidValue = ResultId(System.identityHashCode(this)) |
There was a problem hiding this comment.
These are not guaranteed to be unique. Use the Uid definitions.
LPTK
reviewed
Sep 19, 2025
| def rewriteOneBlk(b: Block) = b match | ||
| case Assign(lhs, Value.Lam(params, body), rest) if !lhs.isInstanceOf[TempSymbol] => | ||
| val newSym = BlockMemberSymbol(lhs.nme, Nil, | ||
| val newSym = BlockMemberSymbol(lhs.nme, syntax.Tree.DummyTermDef(syntax.Fun) :: Nil, |
LPTK
reviewed
Sep 19, 2025
| val sym = BlockMemberSymbol("lambda", Nil, nameIsMeaningful = false) | ||
| val sym = BlockMemberSymbol( | ||
| "lambda", | ||
| syntax.Tree.DummyTermDef(syntax.Fun) :: Nil, |
LPTK
reviewed
Sep 19, 2025
| case _ => N | ||
| val singleCallBms = BlockMemberSymbol(d.sym.nme + "$", Nil) | ||
LPTK
reviewed
Sep 19, 2025
Comment on lines
+314
to
+316
| args(fs): args => | ||
| val tmpSym = TempSymbol(N, "arr") | ||
| Assign(tmpSym, Value.Arr(mut = false, args), k(Value.Ref(tmpSym))) |
There was a problem hiding this comment.
Is this really needed? At the very least, we shouldn't do it when the array is immediately returned or already assigned to a variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
nofibsto the benchmark subproject