Skip to content

Add Java 17 permits keyword to #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2022
Merged

Add Java 17 permits keyword to #3649

merged 1 commit into from
Oct 30, 2022

Conversation

@MBoegers
Copy link
Contributor

@MBoegers MBoegers commented Oct 25, 2022 •
edited
Loading

Java 17 introduced sealed classes/interfaces with EP 409: Sealed Classes. The new keywords sealed and non-sealed were present but permits was missing.

Resolves #3646

Changes

Permits is now a general keyword and the present tests are fixed acordingly.

Checklist

  • Added markup tests, see test/markup/java/titles.expect.txt
  • Updated the changelog at CHANGES.md

@MBoegers MBoegers mentioned this pull request Oct 25, 2022
Closed
2 tasks
joshgoebel
joshgoebel approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@joshgoebel joshgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@joshgoebel joshgoebel merged commit f035aab into highlightjs:main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshgoebel joshgoebel joshgoebel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(java) Sealed Classes keywords

2 participants

@MBoegers @joshgoebel