Skip to content

Fix highlighting of int8, int16, int32, int64 in Angelscript #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 19, 2022
Merged

Fix highlighting of int8, int16, int32, int64 in Angelscript #3464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b7ef11
Swap order of int/uint and their explicit type variations to fix inco…
codecat Jan 19, 2022
d6b9aa2
Updated markup test for Angelscript
codecat Jan 19, 2022
964c5c7
Updated changes.md
codecat Jan 19, 2022
fadf777
Added test for both int and uint64
codecat Jan 19, 2022
cc66f89
Added footnote
codecat Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ Grammars:

- enh(php) named arguments [Wojciech Kania][]
- fix(php) PHP constants [Wojciech Kania][]
- fix(angelscript) incomplete int8, int16, int32, int64 highlighting [Melissa Geels][]

[Wojciech Kania]: https://github.com/wkania
[Melissa Geels]: https://github.com/codecat

## Version 11.4.0

Expand Down
2 changes: 1 addition & 1 deletion src/languages/angelscript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Website: https://www.angelcode.com/angelscript/
export default function(hljs) {
const builtInTypeMode = {
className: 'built_in',
begin: '\\b(void|bool|int|int8|int16|int32|int64|uint|uint8|uint16|uint32|uint64|string|ref|array|double|float|auto|dictionary)'
begin: '\\b(void|bool|int8|int16|int32|int64|int|uint8|uint16|uint32|uint64|uint|string|ref|array|double|float|auto|dictionary)'
};

const objectHandleMode = {
Expand Down
2 changes: 1 addition & 1 deletion test/detect/angelscript/default.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace MyApplication
array<SomeClass@> m_children;
array<array<SomeClass@>> m_subChildren; // Nested templates

int m_thing;
uint64 m_thing;

SomeClass()
{
Expand Down
1 change: 1 addition & 0 deletions test/markup/angelscript/default.expect.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
<span class="hljs-built_in">array<span class="hljs-keyword">&lt;<span class="hljs-built_in">array<span class="hljs-keyword">&lt;<span class="hljs-symbol">SomeClass@</span>&gt;</span></span>&gt;</span></span> m_subChildren; <span class="hljs-comment">// Nested templates</span>

<span class="hljs-built_in">int</span> m_thing;
<span class="hljs-built_in">uint64</span> m_thing2;

SomeClass()
{
Expand Down
1 change: 1 addition & 0 deletions test/markup/angelscript/default.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ namespace MyApplication
array<array<SomeClass@>> m_subChildren; // Nested templates

int m_thing;
uint64 m_thing2;

SomeClass()
{
Expand Down