enh(parser) Refactor parse tree and HTML render into components #2404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
force-pushed
the
parse_tree
branch
from
c703068 to
8c91b6e
Compare
joshgoebel
force-pushed
the
parse_tree
branch
from
8d83d84 to
5a85321
Compare
joshgoebel
changed the title
joshgoebel
force-pushed
the
parse_tree
branch
from
5a85321 to
6e8a0cd
Compare
Member
|
This looks a bit more of an invasive change, I can look this over in-depth later this week or weekend. |
Member
Author
|
Anyone? |
egor-rogov
requested changes
Feb 29, 2020
Collaborator
egor-rogov
left a comment
egor-rogov
left a comment
There was a problem hiding this comment.
Sorry for the delay. See my comments.
Member
Author
|
Please see the last commit, that's kind of the culmination of where I wanted to take this. |
joshgoebel
force-pushed
the
parse_tree
branch
2 times, most recently
from
46d10dc to
cef80f5
Compare
egor-rogov
approved these changes
Feb 29, 2020
- make emitter configurable - mark this API as beta/private for now - make rendering HTML a responsibility of the emitter (though it can of course delegate) That wraps emitting/rendering up nicely into a single object.
joshgoebel
force-pushed
the
parse_tree
branch
from
cef80f5 to
5cbac51
Compare
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the storage of the parse tree and the HTML rendering into their own components and separates them from the tokenizer itself.
Closes #1086