Skip to content

Add @objcMembers to Swift @attributes #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2018
Merged

Add @objcMembers to Swift @attributes #1820

merged 1 commit into from
Sep 5, 2018

Conversation

@berkcebi
Copy link
Contributor

@berkcebi berkcebi commented Sep 5, 2018

Replacing #1634, as the fork was deleted:

Adds @objcMembers to Swift's @attributes list. 🙋‍♀️

@objcMembers is introduced on Swift 4, as documented here: https://developer.apple.com/library/content/documentation/Swift/Conceptual/BuildingCocoaApps/WritingSwiftClassesWithObjective-CBehavior.html

@berkcebi berkcebi mentioned this pull request Sep 5, 2018
Closed
marcoscaceres
marcoscaceres approved these changes Sep 5, 2018
View reviewed changes
Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for redoing the pull request.

@marcoscaceres marcoscaceres merged commit 0ebdfa6 into highlightjs:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@berkcebi @marcoscaceres