(groovy) strings are not allowed inside ternary clauses

[paladox]

If you do for example:

def createCodeStyleMsgBody(build, label) {
    def codeStyleFiles = findCodestyleFilesInLog(build)
    def formattingMsg = label < 0 ? ('The following files need formatting:\n    ' +
        codeStyleFiles.join('\n    ')) : 'All files are correctly formatted'
    def url = build.url + "consoleText"

    return "${Globals.resTicks[build.result]} $formattingMsg\n    (${url})"
}

'The following files need formatting:\n ' is not highlighted correctly as a string, secondly everything after ' + is coloured in blue (so if you create another def after, it colours all that in blue).

[joshgoebel]

Sounds like some issue with expectations around new lines... anyway you could make a jsfiddle of this so we can easily track it over time and confirm it? Or if you want to make an attempt at fixing it that'd be amazing. :-)

You can fork my template:
https://jsfiddle.net/ajoshguy/a1kntyg4/

[paladox]

Hi, here's the jsfiddle https://jsfiddle.net/j4gq5at6/

[joshgoebel]

Thanks, yeah something strange is in the neighborhood there.

[paladox]

@yyyc514 i guess it's because of https://github.com/highlightjs/highlight.js/blob/master/src/highlight.js#L938 (as that piece of text actually includes \n)

[paladox]

Oh, just tested, nope.

[joshgoebel]

No that's not it because the string is terminated, it doesn't bridge multiple lines.

[joshgoebel]

It doesn't like the ternary, but not sure why.

[joshgoebel]

    {
                // catch middle element of the ternary operator
                // to avoid highlight it as a label, named parameter, or map key
                begin: /\?/, end: /\:/
            },

Guessing this is it. It needs to be updated to know that strings are allowed to existing inside ternary's so that string grabs the ":" inside strings, not the ternary rule.