Skip to content

fix client mutation observer check #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2022
Merged

fix client mutation observer check #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/rrweb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@highlight-run/rrweb",
"version": "2.1.8",
"version": "2.1.9",
"description": "record and replay the web",
"scripts": {
"prepare": "npm run prepack",
Expand Down
4 changes: 3 additions & 1 deletion packages/rrweb/src/record/mutation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,9 @@ export default class MutationBuffer {
// ensure shadowHost is a Node, or doc.contains will throw an error
const notInDoc =
!this.doc.contains(n) &&
(!rootShadowHost || !this.doc.contains(rootShadowHost));
(!rootShadowHost ||
!(rootShadowHost instanceof Node) ||
!this.doc.contains(rootShadowHost));
if (!n.parentNode || notInDoc) {
return;
}
Expand Down
13 changes: 13 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,19 @@
minimatch "^3.1.2"
strip-json-comments "^3.1.1"

"@highlight-run/[email protected]":
version "2.1.8"
resolved "https://registry.yarnpkg.com/@highlight-run/rrweb/-/rrweb-2.1.8.tgz#0fc0d05202bb5253937333f38fcc8c8c365b91f7"
integrity sha512-3xcH5Ew6l3thkaPyxh7e2YORO7XUFW89JAuP6W65qJMjg9TIVokaVSfnrg+eMOVvUs3XS3FAaOUU64q4M8whaQ==
dependencies:
"@highlight-run/rrdom" "0.1.17"
"@highlight-run/rrweb-snapshot" "1.1.30"
"@types/css-font-loading-module" "0.0.7"
"@xstate/fsm" "^1.4.0"
base64-arraybuffer "^1.0.1"
fflate "^0.4.4"
mitt "^3.0.0"

"@humanwhocodes/config-array@^0.9.2":
version "0.9.5"
resolved "https://registry.npmjs.org/@humanwhocodes/config-array/-/config-array-0.9.5.tgz"
Expand Down