Skip to content

remove debug logging in canvas worker #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2023
Merged

remove debug logging in canvas worker #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
950ee4d
remove debug logging in canvas worker
Vadman97 Sep 6, 2023
7199abe
fix logic
Vadman97 Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/rrweb/src/record/observers/canvas/canvas-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ export class CanvasManager {
dw: element.width,
dh: element.height,
dataURLOptions: this.options.dataURLOptions,
logDebug: !!this.logger,
},
[bitmap],
);
Expand Down Expand Up @@ -454,6 +455,7 @@ export class CanvasManager {
dw: outputWidth,
dh: outputHeight,
dataURLOptions: options.dataURLOptions,
logDebug: !!this.logger,
},
[bitmap],
);
Expand Down
17 changes: 12 additions & 5 deletions packages/rrweb/src/record/workers/image-bitmap-data-url-worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,18 @@ async function getTransparentBlobFor(
}
}

// `as any` because: https://github.com/Microsoft/TypeScript/issues/20595
const worker: ImageBitmapDataURLResponseWorker = self;
let logDebug: boolean = false;

const debug = (...args: any[]) => {
if (logDebug) {
console.debug(...args);
}
};

// eslint-disable-next-line @typescript-eslint/no-misused-promises
worker.onmessage = async function (e) {
logDebug = !!e.data.logDebug;
if ('OffscreenCanvas' in globalThis) {
const { id, bitmap, width, height, dx, dy, dw, dh, dataURLOptions } =
e.data;
Expand All @@ -71,7 +78,7 @@ worker.onmessage = async function (e) {
// on first try we should check if canvas is transparent,
// no need to save it's contents in that case
if (!lastBlobMap.has(id) && (await transparentBase64) === base64) {
console.debug('[highlight-worker] canvas bitmap is transparent', {
debug('[highlight-worker] canvas bitmap is transparent', {
id,
base64,
});
Expand All @@ -81,13 +88,13 @@ worker.onmessage = async function (e) {

// unchanged
if (lastBlobMap.get(id) === base64) {
console.debug('[highlight-worker] canvas bitmap is unchanged', {
debug('[highlight-worker] canvas bitmap is unchanged', {
id,
base64,
});
return worker.postMessage({ id, status: 'unchanged' });
}
console.debug('[highlight-worker] canvas bitmap processed', {
debug('[highlight-worker] canvas bitmap processed', {
id,
base64,
});
Expand All @@ -104,7 +111,7 @@ worker.onmessage = async function (e) {
});
lastBlobMap.set(id, base64);
} else {
console.debug('[highlight-worker] no offscreencanvas support', {
debug('[highlight-worker] no offscreencanvas support', {
id: e.data.id,
});
return worker.postMessage({ id: e.data.id, status: 'unsupported' });
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,7 @@ export type ImageBitmapDataURLWorkerParams = {
dy: number;
dw: number;
dh: number;
logDebug?: boolean;
};

export type ImageBitmapDataURLWorkerResponse =
Expand Down