General doc page fixes [moved from highlight/highlight.io#449] #4736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a more detailed commit list is at highlight/highlight.io#449
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jay-khatri
requested changes
Mar 29, 2023
Collaborator
jay-khatri
left a comment
jay-khatri
left a comment
There was a problem hiding this comment.
Looks great, a few comments:
- stacking on the guide pages is working for mobil, but now its not side-by-side on desktop?
- mobile dropdown + heading edits:
https://www.loom.com/share/09f4f1bc01d7438b99714c0130ed0dcd - thoughts on headings:
https://www.loom.com/share/a317db40cd8f4534b12aa18bb1419ac8
Member
|
preview should be working now - https://highlight-landing-git-general-doc-fixes-highlight-run.vercel.app/docs/getting-started/client-sdk/angular |
jay-khatri
approved these changes
Apr 8, 2023
Collaborator
jay-khatri
left a comment
jay-khatri
left a comment
There was a problem hiding this comment.
fix session replay, then looks good!
things to follow up on:
- jankiness on links
- smaller headers don't work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Original PR, with a more detailed commit history highlight/highlight.io#449
Make any header linkable(Ran into issues with this, not sure how to fix it)