Avoid setting SFTP rename flags below version 5 #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hierynomus
approved these changes
Dec 22, 2021
|
And thanks again! Totally missed that during the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #652 introduced support for SFTP rename flags, which was released in SSHJ 0.32.0. The
SFTPEngine.rename()method includes the rename flag mask without checking the SFTP operative version, causing communication issues described in #750 and #751.The SFTP Version 5 Section 6.5 specification added support for rename flags, but previous versions such as SFTP Version 3 do not support rename flags.
This pull request changes the behavior and avoids appending the rename flag mask to the SFTP request packet for operative versions less than 5.