Skip to content

Conversation

@dajose
Copy link
Contributor

@dajose dajose commented Apr 12, 2019

Add support for libpcap set_direction method, see #59

@dajose
Copy link
Contributor Author

dajose commented Apr 16, 2019

@asolino what do you think of this proposal?

@asolino
Copy link
Contributor

asolino commented Apr 16, 2019

Hey @dajose

Thanks for the PR! it actually looks good and I think it'll fit well (although haven't run the testcases). I won't be merging this one tho since this project has been transferred to the HelpSystems organization (that I'm not part of). You will be reached out by the new maintainers soon.

@dajose
Copy link
Contributor Author

dajose commented Apr 16, 2019

@asolino someone I can poke?

@asolino
Copy link
Contributor

asolino commented Apr 16, 2019

I'm not sure @dajose . Try emailing oss @ coresecurity.com. HelpSystems owns CoreSecurity now.

@dajose
Copy link
Contributor Author

dajose commented Apr 16, 2019

sure, thanks @asolino :)

@gpotter2
Copy link
Contributor

Let's just hope it actually is transferred to someone :/

Good luck for your next projects asolino, and thanks for the support you provided here 😄

@BobbyAtCore
Copy link
Contributor

Hi @dajose, I'm one of @asolino's former coworkers who's still on the Core Security side and I'll be taking over the maintenance of pcapy. As soon as we get the permissions sorted out, I'll be getting this PR merged in.

@dajose
Copy link
Contributor Author

dajose commented Apr 30, 2019

thanks @BobbyAtCore :) :) :)

@BobbyAtCore BobbyAtCore merged commit 44ada26 into helpsystems:master May 1, 2019
@carlos-jenkins
Copy link

@BobbyAtCore great news!

Would be too much to ask for a new PyPI release that includes this change?

Thanks a lot!

@carlos-jenkins
Copy link

@BobbyAtCore still no release? :)

@BobbyAtCore
Copy link
Contributor

Give me a day or so. I just noticed that everything from GitHub was being eaten by our spamfilter @carlos-jenkins.

@carlos-jenkins
Copy link

This was release in 0.11.5, thanks a lot @BobbyAtCore !

@gpotter2
Copy link
Contributor

gpotter2 commented Oct 22, 2019

@carlos-jenkins I'd advise you to get a version that doesn't contain #61 (comment) 😄
This project is dead, and now dangerously broken. (if that answers secdev/scapy#2057 (comment) 😉)

@carlos-jenkins
Copy link

@gpotter2 thanks for the heads up! It seems that #61 only affects Windows, right? If so, I'll be fine. I'll run the whole test suite just to make sure. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants