Make compile_commands.json order deterministic #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Order entries in the output json file by filename, to make output deterministic. An example of why this is useful: changes in Python, bazel, or `rules_cc` can all change the exact output order in `compile_commands.json`. When my compile commands change as a result of an upstream change in bazel or `rules_cc`, I would like to see what has changed. By making output order deterministic it makes it much simpler to diff the old and new compiler commands json files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order entries in the output json file by filename, to make output deterministic.
An example of why this is useful: changes in Python, bazel, or
rules_cccan all change the exact output order incompile_commands.json. When my compile commands change as a result of an upstream change in bazel orrules_cc, I would like to see what has changed. By making output order deterministic it makes it much simpler to diff the old and new compiler commands json files.