Skip to content

Update path.py: return annotation bool not int #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Update path.py: return annotation bool not int #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions boostedblob/path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ async def exists(path: Union[BasePath, BlobPath, str]) -> int:


@exists.register # type: ignore
async def _cloud_exists(path: CloudPath) -> int:
async def _cloud_exists(path: CloudPath) -> bool:
# TODO: this is two network requests, make it one
for fut in asyncio.as_completed([isfile(path), isdir(path)]):
if await fut:
Expand All @@ -571,7 +571,7 @@ async def _cloud_exists(path: CloudPath) -> int:


@exists.register # type: ignore
async def _local_exists(path: LocalPath) -> int:
async def _local_exists(path: LocalPath) -> bool:
return os.path.exists(path)


Expand Down
Loading