match documentation to upstream C library #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously it had the doc string for `errorMessage`
phadej
approved these changes
Jul 1, 2019
Collaborator
|
debian old-stable seems to have libpq-9.4, so I'm fine with dropping |
Collaborator
|
In fact, we have |
The parenthetical has been included in libpq docs since 9.3. This library already requires libpq >= 9.3.
Contributor
Author
|
Thanks! I updated this branch, removing the old warning. |
robx
added a commit
to robx/postgresql-libpq
that referenced
this pull request
Mar 8, 2023
Merge postgresql-libpq upstream as of 2022-12-29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of mismatches I noticed between docs on the Haskell bindings & on upstream libpq. I'm not sure which versions of libpq this library tries to support. If you only support libpq that still have upstream support, I would prefer to drop the warning about
ntuplesentirely.