Track closed files in the VFS #611
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeryMilkyJoe
force-pushed
the
watch-closed-files
branch
3 times, most recently
from
349249a to
3367359
Compare
michaelpj
reviewed
Jun 10, 2025
lsp/src/Language/LSP/VFS.hs
Outdated
| We are keeping track of this in order to be able to get information | ||
| on virtual files after they were closed. | ||
| -} | ||
| data VirtualFileGhost = VirtualFileGhost |
There was a problem hiding this comment.
Cute, but perhaps better to be boring: ClosedVirtualFile?
There was a problem hiding this comment.
Somehow that name never came to mind, that is much better!
There was a problem hiding this comment.
I thought you were going to change the name?
There was a problem hiding this comment.
Sorry, I forgot to push the changes 🙈
|
@michaelpj Is there anything that still needs to be done, before we can merge this? |
VeryMilkyJoe
force-pushed
the
watch-closed-files
branch
from
3367359 to
527b650
Compare
Add data structure which represents a closed file in the VFS. This structure only stores the language kind of the closed file as of now. The VFS now stores VFS entries which can be either open or closed files.
VeryMilkyJoe
force-pushed
the
watch-closed-files
branch
from
527b650 to
73fefa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add data structure which represents a closed file in the VFS. This structure only stores the language kind of the closed file as of now.
The VFS now stores VFS entries which can be either open or closed files.
This will be used in HLS, to be able to tell whether we are responsible for files which were already closed.