Migrate change-type-signature-plugin to use structured diagnostics #4632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillespie
force-pushed
the
master
branch
2 times, most recently
from
ce74f12 to
120d8ac
Compare
sgillespie
force-pushed
the
master
branch
2 times, most recently
from
5556c3e to
be06dc8
Compare
sgillespie
changed the title
fendor
approved these changes
Jun 20, 2025
plugins/hls-change-type-signature-plugin/src/Ide/Plugin/ChangeTypeSignature.hs
Outdated
Show resolved
Hide resolved
Comment on lines
+211
to
+212
| matchingDiagnostic :: ErrInfo -> Maybe DeclName | ||
| matchingDiagnostic ErrInfo{errInfoContext} = |
There was a problem hiding this comment.
We still need that? Should we open a GHC issue for adding the DeclName context to the error message?
There was a problem hiding this comment.
We still need that?
Sadly, I think we do
Should we open a GHC issue for adding the
DeclNamecontext to the error message?
That would be awesome
|
Stack CI test failure is genuine, otherwise, let's merge! |
20 tasks
sgillespie
force-pushed
the
master
branch
2 times, most recently
from
a9f5b7c to
92bbd8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses using structured diagnostics from GHC (rather than regular expressions) for
hls-change-type-signature-plugin.A couple of notes:
Development.IDE.GHC.Compat.Error?