Skip to content

Display package names of external libraries on hover #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 3, 2021
Merged

Display package names of external libraries on hover #1626

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
351ff51
Display package names of external libraries on hover
berberman Mar 26, 2021
d8cc357
Use dynflags of the current file
berberman Mar 28, 2021
f3e21e3
Merge branch 'master' into hover-pkgname
berberman Mar 28, 2021
c5ab28c
Merge branch 'master' into hover-pkgname
berberman Apr 1, 2021
c8ecaff
Merge branch 'master' into hover-pkgname
berberman Jun 23, 2021
5c338ce
Add tests
berberman Jun 23, 2021
b5878b7
Remove unclear lib name
berberman Jun 23, 2021
8a50dc7
Cleanup imports
berberman Jun 23, 2021
0962f21
Merge branch 'master' into hover-pkgname
berberman Jun 30, 2021
9416e95
Merge branch 'master' into hover-pkgname
mergify[bot] Jul 3, 2021
c52c788
Merge branch 'master' into hover-pkgname
mergify[bot] Jul 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ghcide/src/Development/IDE/Spans/AtPoint.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,13 @@ import Data.Either
import Data.List (isSuffixOf)
import Data.List.Extra (dropEnd1, nubOrd)

import Data.Version (showVersion)
import HieDb hiding (pointCommand)
import Packages (InstalledPackageInfo (packageVersion),
PackageName (..),
lookupPackage,
packageNameString,
sourceLibName)

-- | Gives a Uri for the module, given the .hie file location and the the module info
-- The Bool denotes if it is a boot module
Expand Down Expand Up @@ -219,11 +225,23 @@ atPoint IdeOptions{} (HAR _ hf _ _ kind) (DKMap dm km) pos = listToMaybe $ point
prettyName (Right n, dets) = T.unlines $
wrapHaskell (showNameWithoutUniques n <> maybe "" (" :: " <>) ((prettyType <$> identType dets) <|> maybeKind))
: definedAt n
++ maybeToList (prettyPackageName n)
++ catMaybes [ T.unlines . spanDocToMarkdown <$> lookupNameEnv dm n
]
where maybeKind = fmap showGhc $ safeTyThingType =<< lookupNameEnv km n
prettyName (Left m,_) = showGhc m

prettyPackageName n = do
m <- nameModule_maybe n
let pid = moduleUnitId m
conf <- lookupPackage unsafeGlobalDynFlags pid
let pkgName = T.pack $ packageNameString conf
version = T.pack $ showVersion (packageVersion conf)
libName = case sourceLibName conf of
Just (PackageName x) -> ":" <> T.pack (unpackFS x)
_ -> ""
pure $ " *(" <> pkgName <> "-" <> version <> libName <> ")*"

prettyTypes = map (("_ :: "<>) . prettyType) types
prettyType t = case kind of
HieFresh -> showGhc t
Expand Down