-
Notifications
You must be signed in to change notification settings - Fork 205
Fix build for Windows 7 #1304
Fix build for Windows 7 #1304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
|
In order to minimise rebuilding for people using hie, we try to only bump resolvers once a month. Can we maybe just add the extra dep for GHC 8.6.5 and the nightly stack, until they get bumped at the end of the month? |
|
@alanz of course! cache is very valuable with so many deps |
|
Thanks, LGTM. We can merge this when CI passes |
|
And it just struck me we should add to the cabal file somewhere. |
This makes sure PR haskell#1304 is complete, constraining the cabal build as well, for Windows 7
|
@alanz maybe it would be not neccesary (other than doing a
it doesnt follow pvp but you have the last patched version without hackage revisions in exchange. |
|
Fair enough, but I think I will be happier to actively constrain a lower bound on it, as per #1306 |
unix-time(viahoogle->wai-logger->fast-logger)0.4.7This pr update the resolver for
stack-yamlandstack-8.6.5.yamlto get one with the patched version and addunix-time-0.4.7as exta dependency for the rest of stack config files.