Use LSP MarkupContent for generated documentation

[alanz]

The affects the HoverReply message.

All documentation is now returned in markdown, and it renders much better in emacs-lsp.

[fendor]

Sorry, for my trailing whitespace. Will configure my editor accordingly.

[alanz]

The appveyor fail looks like a transient networking error, rather than an actual fail. And the linux equivalent passes. So I am going to merge (and hold thumbs).

[infinisil]

I'm not sure if this or #1189 is the cause, but after the 0.9.0.0 update, lsp-ui-sideline started showing the raw markdown format:

[alanz]

I don't have that problem, and I am wondering if its because my emacs config explicitly pulls in markdown-mode.

;; ---------------------------------------------------------------------
;; hie lsp stuff

(package-install 'dash-functional)
(package-install 'haskell-mode)
(package-install 'markdown-mode)
(require 'markdown-mode)
(package-install 'ht)
(package-install 'company-lsp)
(package-install 'yasnippet)
(require 'yasnippet)

;; (add-to-list 'load-path "/home/alanz/mysrc/github/alanz/lsp-mode")
(package-install 'lsp-mode)

;; (add-to-list 'load-path "/home/alanz/mysrc/github/alanz/lsp-ui")
(package-install 'lsp-ui)

;; (add-to-list 'load-path "/home/alanz/mysrc/github/alanz/lsp-haskell")
(package-install 'lsp-haskell)

;; New style client ;;;;;;;;;;;;;;
(require 'lsp)
(require 'lsp-haskell)
(add-hook 'haskell-mode-hook #'lsp)
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; ---- From
;;   https://github.com/tigersoldier/company-lsp -------
;;   http://company-mode.github.io/
;(package-install 'company-mode)
;(require 'company-mode)
(add-hook 'after-init-hook 'global-company-mode)

(require 'company-lsp)
(push 'company-lsp company-backends)

[alanz]

FYI, this is what I get

[infinisil]

Doesn't seem to solve it, my config is here and here (there's an implicit package-initialize at the beginning to load all those packages).

I'll probably try to get a minimal example going to reproduce this (but not right now).

[infinisil]

Ahh, so after updating lsp-ui, lsp-mode to latest master and installing markdown-mode, the problem is solved.

So markdown-mode should be a dependency of lsp-haskell probably

[infinisil]

See also emacs-lsp/lsp-ui#172