Get tests working on windows

[lukel97]

Currently stack test fails on windows due to a plethora of errors, so it has been turned off in our AppVeyor builds. (haskell-lsp-test will probably need to be fixed for it)

[fendor]

Do the tests explicitly fail or not terminate? Because currently they do not terminate.

[lukel97]

I am not sure. As far as I'm aware lsp-test builds but doesn't work at runtime on Windows lukel97/lsp-test#28

[jneira]

I am taking a look at this, in both local and appveyor env (with this branch: https://github.com/jneira/haskell-ide-engine/blob/appveyor/appveyor.yml).

[alanz]

@jneira There is also an effort to get this working in Azure, which may be the preferred long-term CI.

See #1238

[jneira]

@alanz thanks for pointed it out!

[jneira]

Hi, i am starting to analyze the tests in windows, and the unit ones are failing for me:

Failures:

  test/unit\LiquidSpec.hs:50:7:
  1) Liquid, liquid haskell plugin, gets annot file paths
       expected: "D:\\dev\\ws\\haskell\\haskell-ide-engine\\test/testdata/liquid/.liquid/Evens.hs.vim.annot"
        but got: "D:\\dev\\ws\\haskell\\haskell-ide-engine\\test\\testdata\\liquid\\.liquid\\Evens.hs.vim.annot"

  To rerun use: --match "/Liquid/liquid haskell plugin/gets annot file paths/"

  test/unit\LiquidSpec.hs:55:5:
  2) Liquid, liquid haskell plugin, reads errors from json file
       uncaught exception: IOException of type NoSuchThing
       D:\dev\ws\haskell\haskell-ide-engine\test\testdata\liquid\.liquid\Evens.hs.json: openBinaryFile: does not exist (No such file or directory)

  To rerun use: --match "/Liquid/liquid haskell plugin/reads errors from json file/"

  test/unit\LiquidSpec.hs:94:5:
  3) Liquid, liquid haskell plugin, reads types from vim.annot file
       uncaught exception: IOException of type NoSuchThing
       D:\dev\ws\haskell\haskell-ide-engine\test\testdata\liquid\.liquid\Evens.hs.vim.annot: openFile: does not exist (No such file or directory)

  To rerun use: --match "/Liquid/liquid haskell plugin/reads types from vim.annot file/"

  test\unit\LiquidSpec.hs:111:7:
  4) Liquid, liquid haskell plugin, reads types from vim.annot file 2
       uncaught exception: IOException of type UserError
       user error (Pattern match failure in do expression at test\unit\LiquidSpec.hs:111:7-13)

  To rerun use: --match "/Liquid/liquid haskell plugin/reads types from vim.annot file 2/"

I have liquid and z3 installed and i exeuted the test in mingw64

[jneira]

Not sure if it is related but liquid test/testdata/liquid/Even.hs fails with

realgcc.exe: fatal error: no input files
compilation terminated.
LiquidHaskell Version 0.8.2.4
Copyright 2013-18 Regents of the University of California. All Rights Reserved.

liquid.exe: `gcc.exe' failed in phase `gcc'. (Exit code: 1)

[jneira]

I've tried to build liquidhaskell from source but i've got another error, opened ucsd-progsys/liquidhaskell#1527

[jneira]

In the bright side, wrapper-test, dispatcher-test and plugin-dispatcher-test suites pass all tests

[jneira]

After installing z3 from https://github.com/Z3Prover/z3/releases/download/Z3-4.8.5/z3-4.8.5-x64-win.zip
liquidhaskell is able to generate its files under .liquid and the failures of unit-test have change to:

Failures:

  test/unit\LiquidSpec.hs:50:7:
  1) Liquid, liquid haskell plugin, gets annot file paths
       expected: "D:\\ws\\haskell\\haskell-ide-engine\\test/testdata/liquid/.liquid/Evens.hs.vim.annot"
        but got: "D:\\ws\\haskell\\haskell-ide-engine\\test\\testdata\\liquid\\.liquid\\Evens.hs.vim.annot"

  To rerun use: --match "/Liquid/liquid haskell plugin/gets annot file paths/"

  test/unit\LiquidSpec.hs:63:7:
  2) Liquid, liquid haskell plugin, reads errors from json file
       expected: LP {line = 9, column = 8}
        but got: LP {line = 9, column = 12}

  To rerun use: --match "/Liquid/liquid haskell plugin/reads errors from json file/"

  test/unit\LiquidSpec.hs:100:7:
  3) Liquid, liquid haskell plugin, reads types from vim.annot file
       expected: [LE {start = LP {line = 1, column = 1}, stop = LP {line = 1, column = 1}, message = "GHC.Types.Module"},LE {start = LP {line = 6, column = 1}, stop = LP {line = 6, column = 10}, message = "[{v : GHC.Types.Int | v mod 2 == 0}]"}]
        but got: [LE {start = LP {line = 1, column = 1}, stop = LP {line = 1, column = 1}, message = "GHC.Types.Module"},LE {start = LP {line = 6, column = 1}, stop = LP {line = 6, column = 10}, message = "[{VV : GHC.Types.Int | VV mod 2 == 0}]"}]

  To rerun use: --match "/Liquid/liquid haskell plugin/reads types from vim.annot file/"

  test/unit\LiquidSpec.hs:112:7:
  4) Liquid, liquid haskell plugin, reads types from vim.annot file 2
       expected: [LE {start = LP {line = 1, column = 1}, stop = LP {line = 1, column = 1}, message = "GHC.Types.Module"},LE {start = LP {line = 6, column = 1}, stop = LP {line = 6, column = 10}, message = "[{v : GHC.Types.Int | v mod 2 == 0}]"}]
        but got: [LE {start = LP {line = 1, column = 1}, stop = LP {line = 1, column = 1}, message = "GHC.Types.Module"},LE {start = LP {line = 6, column = 1}, stop = LP {line = 6, column = 10}, message = "[{VV : GHC.Types.Int | VV mod 2 == 0}]"}]

  To rerun use: --match "/Liquid/liquid haskell plugin/reads types from vim.annot file 2/"

The results are very close and the first one seems to be easily fixed normalizing paths.

[jneira]

The other errors maybe are caused by the liquidhaskell version i had to use in windows (built from master), the actual version used by hie is the lastest one in hackage (0.8.2.4) and it fails for me with ucsd-progsys/liquidhaskell#1177