Skip to content

Conversation

@geekosaur
Copy link
Collaborator

@geekosaur geekosaur commented Apr 22, 2024

The upstream zlib package was recently reorganized (haskell/zlib@c3809b5) in a way that caused our git fetch test to fail. Update it to match.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

The upstream zlib package was recently reorganized in a way that
caused our git fetch test to fail. Update it to match.
@geekosaur
Copy link
Collaborator Author

Since the cabal-install test suite will fail until this goes in, we probably want to fast-track it.

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great detective work!

@Mikolaj Mikolaj added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Apr 22, 2024
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job!

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label Apr 22, 2024
@mergify mergify bot merged commit 959d72b into haskell:master Apr 22, 2024
@Mikolaj
Copy link
Member

Mikolaj commented Apr 22, 2024

Nobody objected here not on the channel, so it went through the express way. Let's also fast-track the backport.

@Mikolaj
Copy link
Member

Mikolaj commented Apr 22, 2024

@mergify backport 3.12

@mergify
Copy link
Contributor

mergify bot commented Apr 22, 2024

backport 3.12

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cabal-install: tests/unit-tests merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants